Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Side by Side Diff: mojo/services/view_manager/test_change_tracker.cc

Issue 308763004: Minor cleanup of view manager test (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/services/view_manager/test_change_tracker.h" 5 #include "mojo/services/view_manager/test_change_tracker.h"
6 6
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "mojo/common/common_type_converters.h" 9 #include "mojo/common/common_type_converters.h"
10 #include "mojo/services/public/cpp/geometry/geometry_type_converters.h" 10 #include "mojo/services/public/cpp/geometry/geometry_type_converters.h"
11 #include "mojo/services/public/cpp/view_manager/util.h" 11 #include "mojo/services/public/cpp/view_manager/util.h"
12 12
13 namespace mojo { 13 namespace mojo {
14 namespace view_manager { 14 namespace view_manager {
15 namespace service { 15 namespace service {
16 16
17 std::string NodeIdToString(TransportNodeId id) { 17 std::string NodeIdToString(TransportNodeId id) {
18 return (id == 0) ? "null" : 18 return (id == 0) ? "null" :
19 base::StringPrintf("%d,%d", HiWord(id), LoWord(id)); 19 base::StringPrintf("%d,%d", HiWord(id), LoWord(id));
20 } 20 }
21 21
22 namespace { 22 namespace {
23 23
24 void INodesToTestNodes(const Array<INodePtr>& data,
25 std::vector<TestNode>* test_nodes) {
26 for (size_t i = 0; i < data.size(); ++i) {
27 TestNode node;
28 node.parent_id = data[i]->parent_id;
29 node.node_id = data[i]->node_id;
30 node.view_id = data[i]->view_id;
31 test_nodes->push_back(node);
32 }
33 }
34
35 std::string RectToString(const gfx::Rect& rect) { 24 std::string RectToString(const gfx::Rect& rect) {
36 return base::StringPrintf("%d,%d %dx%d", rect.x(), rect.y(), rect.width(), 25 return base::StringPrintf("%d,%d %dx%d", rect.x(), rect.y(), rect.width(),
37 rect.height()); 26 rect.height());
38 } 27 }
39 28
40 std::string ChangeToDescription1(const Change& change) { 29 std::string ChangeToDescription1(const Change& change) {
41 switch (change.type) { 30 switch (change.type) {
42 case CHANGE_TYPE_CONNECTION_ESTABLISHED: 31 case CHANGE_TYPE_CONNECTION_ESTABLISHED:
43 return "OnConnectionEstablished"; 32 return "OnConnectionEstablished";
44 33
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 82
94 std::string ChangeNodeDescription(const std::vector<Change>& changes) { 83 std::string ChangeNodeDescription(const std::vector<Change>& changes) {
95 if (changes.size() != 1) 84 if (changes.size() != 1)
96 return std::string(); 85 return std::string();
97 std::vector<std::string> node_strings(changes[0].nodes.size()); 86 std::vector<std::string> node_strings(changes[0].nodes.size());
98 for (size_t i = 0; i < changes[0].nodes.size(); ++i) 87 for (size_t i = 0; i < changes[0].nodes.size(); ++i)
99 node_strings[i] = "[" + changes[0].nodes[i].ToString() + "]"; 88 node_strings[i] = "[" + changes[0].nodes[i].ToString() + "]";
100 return JoinString(node_strings, ','); 89 return JoinString(node_strings, ',');
101 } 90 }
102 91
92 void INodesToTestNodes(const Array<INodePtr>& data,
93 std::vector<TestNode>* test_nodes) {
94 for (size_t i = 0; i < data.size(); ++i) {
95 TestNode node;
96 node.parent_id = data[i]->parent_id;
97 node.node_id = data[i]->node_id;
98 node.view_id = data[i]->view_id;
99 test_nodes->push_back(node);
100 }
101 }
102
103 Change::Change() 103 Change::Change()
104 : type(CHANGE_TYPE_CONNECTION_ESTABLISHED), 104 : type(CHANGE_TYPE_CONNECTION_ESTABLISHED),
105 connection_id(0), 105 connection_id(0),
106 change_id(0), 106 change_id(0),
107 node_id(0), 107 node_id(0),
108 node_id2(0), 108 node_id2(0),
109 node_id3(0), 109 node_id3(0),
110 view_id(0), 110 view_id(0),
111 view_id2(0) {} 111 view_id2(0) {}
112 112
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
204 std::string TestNode::ToString() const { 204 std::string TestNode::ToString() const {
205 return base::StringPrintf("node=%s parent=%s view=%s", 205 return base::StringPrintf("node=%s parent=%s view=%s",
206 NodeIdToString(node_id).c_str(), 206 NodeIdToString(node_id).c_str(),
207 NodeIdToString(parent_id).c_str(), 207 NodeIdToString(parent_id).c_str(),
208 NodeIdToString(view_id).c_str()); 208 NodeIdToString(view_id).c_str());
209 } 209 }
210 210
211 } // namespace service 211 } // namespace service
212 } // namespace view_manager 212 } // namespace view_manager
213 } // namespace mojo 213 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/services/view_manager/test_change_tracker.h ('k') | mojo/services/view_manager/view_manager_connection_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698