Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 308743006: Revert 273652 "Host extensions" (Closed)

Created:
6 years, 6 months ago by mattm
Modified:
6 years, 6 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273652 "Host extensions" gyp failure on Win: Exception: Missing input files: C:\b\build\slave\Win\build\src\remoting\host\extension.h C:\b\build\slave\Win\build\src\remoting\host\extension_session.h > Host extensions > > This CL introduces HostExtension, an interface for classes that > extend the host with non-core functionality. > > Extensions are added to the ChromotingHost. They are used to compile > the list of capabilities reported to the client, which can be used by > the client to determine the availability of the extension. > > When a client connects, a HostExtension has the opportunity to create > an HostExtensionSession to hold client/extension state, and to handle > extension messages from that client. > > BUG= > > Review URL: https://codereview.chromium.org/301453003 TBR=dcaiafa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -365 lines) Patch
M trunk/src/remoting/host/chromoting_host.h View 5 chunks +1 line, -11 lines 0 comments Download
M trunk/src/remoting/host/chromoting_host.cc View 3 chunks +0 lines, -24 lines 0 comments Download
M trunk/src/remoting/host/client_session.h View 6 chunks +0 lines, -22 lines 0 comments Download
M trunk/src/remoting/host/client_session.cc View 6 chunks +1 line, -31 lines 0 comments Download
M trunk/src/remoting/host/client_session_unittest.cc View 10 chunks +1 line, -200 lines 0 comments Download
D trunk/src/remoting/host/host_extension.h View 1 chunk +0 lines, -40 lines 0 comments Download
D trunk/src/remoting/host/host_extension_session.h View 1 chunk +0 lines, -33 lines 0 comments Download
M trunk/src/remoting/host/host_mock_objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/remoting/protocol/session_config.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/remoting/remoting_host.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mattm
6 years, 6 months ago (2014-05-30 00:05:52 UTC) #1
mattm
6 years, 6 months ago (2014-05-30 00:06:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r273674 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698