Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: Source/core/css/parser/BisonCSSParser-in.cpp

Issue 308733005: Fix assert on unknown rule type in the BisonCSSParser::endRuleHeader. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/MediaQuerySetTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/BisonCSSParser-in.cpp
diff --git a/Source/core/css/parser/BisonCSSParser-in.cpp b/Source/core/css/parser/BisonCSSParser-in.cpp
index add82fdaf1d377746676bde932d0c69ba0c95e40..345d96023333c477d5abae7b236c323fc4baa5e3 100644
--- a/Source/core/css/parser/BisonCSSParser-in.cpp
+++ b/Source/core/css/parser/BisonCSSParser-in.cpp
@@ -2010,7 +2010,9 @@ void BisonCSSParser::startRuleHeader(CSSRuleSourceData::Type ruleType)
void BisonCSSParser::endRuleHeader()
{
- ASSERT(m_ruleHeaderType != CSSRuleSourceData::UNKNOWN_RULE);
+ if (m_ruleHeaderType == CSSRuleSourceData::UNKNOWN_RULE)
Julien - ping for review 2014/06/06 20:13:06 I don't think it's the right fix: we shouldn't be
+ return;
+
m_ruleHeaderType = CSSRuleSourceData::UNKNOWN_RULE;
if (m_observer) {
ASSERT(m_ruleHasHeader);
« no previous file with comments | « Source/core/css/MediaQuerySetTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698