Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Side by Side Diff: Source/core/css/parser/BisonCSSParserTest.cpp

Issue 308733005: Fix assert on unknown rule type in the BisonCSSParser::endRuleHeader. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSGrammar.y ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/css/parser/BisonCSSParser.h" 6 #include "core/css/parser/BisonCSSParser.h"
7 7
8 #include "core/css/CSSTimingFunctionValue.h" 8 #include "core/css/CSSTimingFunctionValue.h"
9 #include "core/css/MediaList.h"
10 #include "core/css/StyleRule.h"
9 #include "platform/animation/TimingFunction.h" 11 #include "platform/animation/TimingFunction.h"
12 #include "wtf/dtoa/utils.h"
10 13
11 #include <gtest/gtest.h> 14 #include <gtest/gtest.h>
12 15
13 namespace blink { 16 namespace blink {
14 17
15 TEST(BisonCSSParserTest, ParseAnimationTimingFunctionValue) 18 TEST(BisonCSSParserTest, ParseAnimationTimingFunctionValue)
16 { 19 {
17 RefPtrWillBeRawPtr<CSSValue> timingFunctionValue; 20 RefPtrWillBeRawPtr<CSSValue> timingFunctionValue;
18 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("eas e"); 21 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("eas e");
19 EXPECT_EQ(CSSValueEase, toCSSPrimitiveValue(timingFunctionValue.get())->getV alueID()); 22 EXPECT_EQ(CSSValueEase, toCSSPrimitiveValue(timingFunctionValue.get())->getV alueID());
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("ste ps(3)"); 60 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("ste ps(3)");
58 EXPECT_TRUE(CSSStepsTimingFunctionValue::create(3, StepsTimingFunction::Step AtEnd)->equals(toCSSStepsTimingFunctionValue(*timingFunctionValue.get()))); 61 EXPECT_TRUE(CSSStepsTimingFunctionValue::create(3, StepsTimingFunction::Step AtEnd)->equals(toCSSStepsTimingFunctionValue(*timingFunctionValue.get())));
59 62
60 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("cub ic-bezier(0.1, 5, 0.23, 0)"); 63 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("cub ic-bezier(0.1, 5, 0.23, 0)");
61 EXPECT_TRUE(CSSCubicBezierTimingFunctionValue::create(0.1, 5, 0.23, 0)->equa ls(toCSSCubicBezierTimingFunctionValue(*timingFunctionValue.get()))); 64 EXPECT_TRUE(CSSCubicBezierTimingFunctionValue::create(0.1, 5, 0.23, 0)->equa ls(toCSSCubicBezierTimingFunctionValue(*timingFunctionValue.get())));
62 65
63 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("cub ic-bezier(0.1, 0, 4, 0.4)"); 66 timingFunctionValue = BisonCSSParser::parseAnimationTimingFunctionValue("cub ic-bezier(0.1, 0, 4, 0.4)");
64 EXPECT_EQ(0, timingFunctionValue.get()); 67 EXPECT_EQ(0, timingFunctionValue.get());
65 } 68 }
66 69
70 static void testMediaQuery(const char* expected, MediaQuerySet& querySet)
71 {
72 const WillBeHeapVector<OwnPtrWillBeMember<MediaQuery> >& queryVector = query Set.queryVector();
73 size_t queryVectorSize = queryVector.size();
74 StringBuilder output;
75
76 for (size_t i = 0; i < queryVectorSize; ) {
77 String queryText = queryVector[i]->cssText();
78 output.append(queryText);
79 ++i;
80 if (i >= queryVectorSize)
81 break;
82 output.append(", ");
83 }
84 ASSERT_STREQ(expected, output.toString().ascii().data());
85 }
86
87 TEST(BisonCSSParserTest, MediaQuery)
88 {
89 struct {
90 const char* input;
91 const char* output;
92 } testCases[] = {
93 {"@media s} {}", "not all"},
94 {"@media } {}", "not all"},
95 {"@media tv {}", "tv"},
96 {"@media tv, screen {}", "tv, screen"},
97 {"@media s}, tv {}", "not all, tv"},
98 {"@media tv, screen and (}) {}", "tv, not all"},
99 };
100
101 BisonCSSParser parser(strictCSSParserContext());
102
103 for (unsigned i = 0; i < ARRAY_SIZE(testCases); ++i) {
104 RefPtrWillBeRawPtr<StyleRuleBase> rule = parser.parseRule(nullptr, Strin g(testCases[i].input));
105
106 EXPECT_TRUE(rule->isMediaRule());
107 testMediaQuery(testCases[i].output, *static_cast<StyleRuleMedia*>(rule.g et())->mediaQueries());
108 }
109 }
110
67 } // namespace blink 111 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/css/CSSGrammar.y ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698