Fix desynched GPU stencil mask cache values.

Fix desynched GPU stencil mask cache values.

In a few places, the command buffer used glStencilMask directly
instead of calling through to the helper function which updated
the mask cache values. This could cause some strange behaviour
in ANGLE, such as the front and back stencil masks getting split.
The split mask values could cause unexpected GL errors during draw.

BUG=378754
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274395

[Jamie Madill, 2014-06-02 19:42:35]

Please take a look-see!

[Zhenyao Mo, 2014-06-02 20:33:52]

Please fix format.  Otherwise looks good.

https://codereview.chromium.org/308703010/diff/1/gpu/command_buffer/service/g...
File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):

https://codereview.chromium.org/308703010/diff/1/gpu/command_buffer/service/g...
gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:732: if
(ignore_cached_state_for_test_ ||
indent is 2 instead of 4

[Jamie Madill, 2014-06-02 20:54:25]

On 2014/06/02 20:33:52, Zhenyao Mo wrote:
> Please fix format.  Otherwise looks good.
> 
>
https://codereview.chromium.org/308703010/diff/1/gpu/command_buffer/service/g...
> File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):
> 
>
https://codereview.chromium.org/308703010/diff/1/gpu/command_buffer/service/g...
> gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:732: if
> (ignore_cached_state_for_test_ ||
> indent is 2 instead of 4

Fixed, PTAL!

[Zhenyao Mo, 2014-06-02 20:56:46]

On 2014/06/02 20:54:25, Jamie Madill wrote:
> On 2014/06/02 20:33:52, Zhenyao Mo wrote:
> > Please fix format.  Otherwise looks good.
> > 
> >
>
https://codereview.chromium.org/308703010/diff/1/gpu/command_buffer/service/g...
> > File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (right):
> > 
> >
>
https://codereview.chromium.org/308703010/diff/1/gpu/command_buffer/service/g...
> > gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:732: if
> > (ignore_cached_state_for_test_ ||
> > indent is 2 instead of 4
> 
> Fixed, PTAL!

LGTM if gpu_unittests pass

[Jamie Madill, 2014-06-02 20:59:27]

The CQ bit was checked by jmadill@chromium.org

[commit-bot: I haz the power, 2014-06-02 21:02:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jmadill@chromium.org/308703010/20001

[commit-bot: I haz the power, 2014-06-03 01:00:38]

Change committed as 274395