Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: pkg/analysis_server/test/domain_server_test.dart

Issue 308703005: Extract constants into separate libarary. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_server_test.dart
diff --git a/pkg/analysis_server/test/domain_server_test.dart b/pkg/analysis_server/test/domain_server_test.dart
index 3ac3eb08d6b51644cbd1ce4315cf5df07aef272c..be58c0b0a6ad924e5995cb09e6103cbec6e28df8 100644
--- a/pkg/analysis_server/test/domain_server_test.dart
+++ b/pkg/analysis_server/test/domain_server_test.dart
@@ -5,6 +5,7 @@
library test.domain.server;
import 'package:analysis_server/src/analysis_server.dart';
+import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_server.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_server/src/resource.dart';
@@ -25,12 +26,12 @@ main() {
group('ServerDomainHandler', () {
test('getVersion', () {
- var request = new Request('0', ServerDomainHandler.GET_VERSION_METHOD);
+ var request = new Request('0', METHOD_GET_VERSION);
var response = handler.handleRequest(request);
expect(response.toJson(), equals({
Response.ID: '0',
Response.RESULT: {
- ServerDomainHandler.VERSION_RESULT: '0.0.1'
+ VERSION: '0.0.1'
}
}));
});
@@ -38,12 +39,12 @@ main() {
group('setSubscriptions', () {
Request request;
setUp(() {
- request = new Request('0', ServerDomainHandler.SET_SUBSCRIPTIONS_METHOD);
+ request = new Request('0', METHOD_SET_SUBSCRIPTIONS);
});
test('invalid service name', () {
request.setParameter(
- ServerDomainHandler.SUBSCRIPTIONS_PARAMETER,
+ SUBSCRIPTIONS,
['noSuchService']);
var response = handler.handleRequest(request);
expect(response, isResponseFailure('0'));
@@ -53,7 +54,7 @@ main() {
expect(server.serverServices, isEmpty);
// send request
request.setParameter(
- ServerDomainHandler.SUBSCRIPTIONS_PARAMETER,
+ SUBSCRIPTIONS,
[ServerService.STATUS.name]);
var response = handler.handleRequest(request);
expect(response, isResponseSuccess('0'));
@@ -65,7 +66,7 @@ main() {
test('shutdown', () {
expect(server.running, isTrue);
// send request
- var request = new Request('0', ServerDomainHandler.SHUTDOWN_METHOD);
+ var request = new Request('0', METHOD_SHUTDOWN);
var response = handler.handleRequest(request);
expect(response, isResponseSuccess('0'));
// server is down
« no previous file with comments | « pkg/analysis_server/test/domain_context_test.dart ('k') | pkg/analysis_server/test/physical_resource_provider_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698