Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: pkg/analysis_server/test/domain_context_test.dart

Issue 308703005: Extract constants into separate libarary. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/domain_context_test.dart
diff --git a/pkg/analysis_server/test/domain_context_test.dart b/pkg/analysis_server/test/domain_context_test.dart
index adaf6f9f9a2ac117940519c00f3023b868f95e71..bd123a0eb289de57e0d9af8f7a4cba006618a096 100644
--- a/pkg/analysis_server/test/domain_context_test.dart
+++ b/pkg/analysis_server/test/domain_context_test.dart
@@ -8,6 +8,7 @@ import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer/src/generated/source_io.dart';
import 'package:analysis_server/src/analysis_server.dart';
+import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_context.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_server/src/resource.dart';
@@ -58,15 +59,14 @@ class ContextDomainHandlerTest {
AnalysisServer server = new AnalysisServer(
new MockServerChannel(),
PhysicalResourceProvider.INSTANCE);
- Request request = new Request('0', ContextDomainHandler.APPLY_CHANGES_NAME);
+ Request request = new Request('0', APPLY_CHANGES_NAME);
ContextDomainHandler handler = new ContextDomainHandler(server);
SourceFactory sourceFactory = new SourceFactory([new FileUriResolver()]);
ChangeSet changeSet = handler.createChangeSet(request, sourceFactory,
- new RequestDatum(request, ContextDomainHandler.CHANGES_PARAM, {
- ContextDomainHandler.ADDED_PARAM: ['ffile:/one.dart'],
- ContextDomainHandler.MODIFIED_PARAM: [],
- ContextDomainHandler.REMOVED_PARAM: ['ffile:/two.dart',
- 'ffile:/three.dart']
+ new RequestDatum(request, CHANGES_PARAM, {
+ ADDED: ['ffile:/one.dart'],
+ MODIFIED_PARAM: [],
+ REMOVED: ['ffile:/two.dart', 'ffile:/three.dart']
}));
expect(changeSet.addedSources, hasLength(equals(1)));
expect(changeSet.changedSources, hasLength(equals(0)));
@@ -77,12 +77,12 @@ class ContextDomainHandlerTest {
AnalysisServer server = new AnalysisServer(
new MockServerChannel(),
PhysicalResourceProvider.INSTANCE);
- Request request = new Request('0', ContextDomainHandler.APPLY_CHANGES_NAME);
+ Request request = new Request('0', APPLY_CHANGES_NAME);
ContextDomainHandler handler = new ContextDomainHandler(server);
SourceFactory sourceFactory = new SourceFactory([new FileUriResolver()]);
ChangeSet changeSet = handler.createChangeSet(request, sourceFactory,
- new RequestDatum(request, ContextDomainHandler.CHANGES_PARAM, {
- ContextDomainHandler.ADDED_PARAM: ['ffile:/one.dart'],
+ new RequestDatum(request, CHANGES_PARAM, {
+ ADDED: ['ffile:/one.dart'],
}));
expect(changeSet.addedSources, hasLength(equals(1)));
expect(changeSet.changedSources, hasLength(equals(0)));
« no previous file with comments | « pkg/analysis_server/test/domain_analysis_test.dart ('k') | pkg/analysis_server/test/domain_server_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698