Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 308703004: Exclude ppapi_tests dep when enable_plugins=0. (Closed)

Created:
6 years, 6 months ago by teravest
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Exclude ppapi_tests dep when enable_plugins=0. We shouldn't include the ppapi_tests dependency when enable_plugins=0 is true. In fact, we should probably get rid of most of the ppapi dependencies in that case, but this change fixes a regression on one of the builders. BUG=379018 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273862

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/content_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
teravest
6 years, 6 months ago (2014-05-30 15:11:00 UTC) #1
dmichael (off chromium)
lgtm
6 years, 6 months ago (2014-05-30 15:15:23 UTC) #2
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 6 months ago (2014-05-30 15:15:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/308703004/1
6 years, 6 months ago (2014-05-30 15:16:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 16:35:58 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 16:38:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/12252)
6 years, 6 months ago (2014-05-30 16:38:52 UTC) #7
teravest
6 years, 6 months ago (2014-05-30 17:09:20 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 manually as r273862 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698