Use the intrinsic version of the Interlocked* functions.

base/atomicops_internals_x86_msvc.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is an internal atomic implementation, use base/atomicops.h instead.
 
 #ifndef BASE_ATOMICOPS_INTERNALS_X86_MSVC_H_
 #define BASE_ATOMICOPS_INTERNALS_X86_MSVC_H_
 
 #include <windows.h>
 
+#include <intrin.h>
+
 #include "base/macros.h"
 
 #if defined(ARCH_CPU_64_BITS)
 // windows.h #defines this (only on x64). This causes problems because the
 // public API also uses MemoryBarrier at the public name for this fence. So, on
 // X64, undef it, and call its documented
 // (http://msdn.microsoft.com/en-us/library/windows/desktop/ms684208.aspx)
 // implementation directly.
 #undef MemoryBarrier
 #endif
 
 namespace base {
 namespace subtle {
 
+// The Interlocked* functions doesn't resolve to their intrinsics

[Sigurður Ásgeirsson, 2014/06/05 17:41:09]

nit: doesn't ->don't

Also mention this is on ia32/x86 only, as from what I see on x64 the
Interlocked* functions default to defines directing them to intrinsics?

+// counterpart, we need to explicitly call the _Interlocked* variant.
+#pragma intrinsic(_InterlockedCompareExchange)

[Sigurður Ásgeirsson, 2014/06/04 15:12:54]

do you need even this? Doesn't <intrin.h> declare this for you?

[Sébastien Marchand, 2014/06/04 15:21:02]

Nop, it seems that I've to explicitly use the intrinsic pragma...
(http://msdn.microsoft.com/en-us/library/26td21ds(v=vs.100).aspx, and see here
for an example http://msdn.microsoft.com/en-us/library/f24ya7ct(v=vs.100).aspx)

I wonder if we could use the /Oi compiler flag on our builds....
(http://msdn.microsoft.com/en-us/library/f99tchzc(v=vs.100).aspx)

[Sigurður Ásgeirsson, 2014/06/05 17:41:09]

Ah, interesting. Turns out <intrin.h> gives you declarations for these functions
but no #pragma intrin ...

+#pragma intrinsic(_InterlockedExchange)
+#pragma intrinsic(_InterlockedExchangeAdd)
+
 inline Atomic32 NoBarrier_CompareAndSwap(volatile Atomic32* ptr,
                                          Atomic32 old_value,
                                          Atomic32 new_value) {
-  LONG result = InterlockedCompareExchange(
+  LONG result = _InterlockedCompareExchange(
       reinterpret_cast<volatile LONG*>(ptr),
       static_cast<LONG>(new_value),
       static_cast<LONG>(old_value));
   return static_cast<Atomic32>(result);
 }
 
 inline Atomic32 NoBarrier_AtomicExchange(volatile Atomic32* ptr,
                                          Atomic32 new_value) {
-  LONG result = InterlockedExchange(
+  LONG result = _InterlockedExchange(
       reinterpret_cast<volatile LONG*>(ptr),
       static_cast<LONG>(new_value));
   return static_cast<Atomic32>(result);
 }
 
 inline Atomic32 Barrier_AtomicIncrement(volatile Atomic32* ptr,
                                         Atomic32 increment) {
-  return InterlockedExchangeAdd(
+  return _InterlockedExchangeAdd(
       reinterpret_cast<volatile LONG*>(ptr),
       static_cast<LONG>(increment)) + increment;
 }
 
 inline Atomic32 NoBarrier_AtomicIncrement(volatile Atomic32* ptr,
                                           Atomic32 increment) {
   return Barrier_AtomicIncrement(ptr, increment);
 }
 
 #if !(defined(_MSC_VER) && _MSC_VER >= 1400)
@@ skipping 130 matching lines @@
   return NoBarrier_CompareAndSwap(ptr, old_value, new_value);
 }
 
 
 #endif  // defined(_WIN64)
 
 }  // namespace base::subtle
 }  // namespace base
 
 #endif  // BASE_ATOMICOPS_INTERNALS_X86_MSVC_H_