Issue 308683010: Instrumented libraries: do not instrument zlib1g.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308683010: Instrumented libraries: do not instrument zlib1g. (Closed)

Created:
6 years, 6 months ago by earthdok

Modified:
6 years, 6 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Instrumented libraries: do not instrument zlib1g. It somehow causes unresolved symbol errors when building other packages. Let's see if we can skip instrumenting it without breaking MSan builds. BUG=313751 R=glider@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274265

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	third_party/instrumented_libraries/instrumented_libraries.gyp	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

earthdok

6 years, 6 months ago (2014-06-02 17:02:54 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r274265 (presubmit successful).