Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 308683007: Rename childrenAffectedBy methods and constants. (Closed)

Created:
6 years, 6 months ago by rune
Modified:
6 years, 6 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Visibility:
Public.

Description

Rename childrenAffectedBy methods and constants. For :hover, :active, :focus, and :drag, childrenAffectedBy really means that descendants, or siblings, or elements in the siblings' subtrees may be affected. Methods and constants are renamed to reflect that. R=esprehn@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175232

Patch Set 1 #

Patch Set 2 : Renamed as proposed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M Source/core/css/AffectedByFocusTest.cpp View 1 9 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/ContainerNode.h View 1 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/page/TouchAdjustment.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rune
The names are pretty long. Any shorter names which encompass the whole truth?
6 years, 6 months ago (2014-06-01 17:34:41 UTC) #1
esprehn
Just use childrenOrSiblingsAffectedByFoo. I don't think we need all that verbosity. To unsubscribe from this ...
6 years, 6 months ago (2014-06-01 19:37:30 UTC) #2
rune
On 2014/06/01 19:37:30, esprehn wrote: > Just use childrenOrSiblingsAffectedByFoo. > > I don't think we ...
6 years, 6 months ago (2014-06-01 20:14:00 UTC) #3
esprehn
lgtm
6 years, 6 months ago (2014-06-01 22:12:52 UTC) #4
rune
The CQ bit was checked by rune@opera.com
6 years, 6 months ago (2014-06-01 22:17:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/308683007/20001
6 years, 6 months ago (2014-06-01 22:17:52 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-01 23:07:24 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 00:17:44 UTC) #8
Message was sent while issue was closed.
Change committed as 175232

Powered by Google App Engine
This is Rietveld 408576698