Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 308683004: Revert "[NaCl SDK] Temporarily disable SocketTestTCP.Listen test under PNaCl" (Closed)

Created:
6 years, 6 months ago by jvoung (off chromium)
Modified:
6 years, 6 months ago
Reviewers:
binji, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Visibility:
Public.

Description

Revert "[NaCl SDK] Temporarily disable SocketTestTCP.Listen test under PNaCl" This reverts commit bb6f7fd33e294c8422c12b31ca5a4514ef6d0171. PNaCl changed was reverted, so this should work again. BUG=377084 NOTRY=true (naclsdk only) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M native_client_sdk/src/tests/nacl_io_socket_test/socket_test.cc View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvoung (off chromium)
6 years, 6 months ago (2014-05-29 18:53:09 UTC) #1
binji
lgtm % trybots
6 years, 6 months ago (2014-05-29 19:09:35 UTC) #2
jvoung (off chromium)
The CQ bit was checked by jvoung@chromium.org
6 years, 6 months ago (2014-05-29 21:04:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@chromium.org/308683004/1
6 years, 6 months ago (2014-05-29 21:05:37 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 23:46:43 UTC) #5
Message was sent while issue was closed.
Change committed as 273664

Powered by Google App Engine
This is Rietveld 408576698