Chromium Code Reviews| Index: ash/shell.cc |
| diff --git a/ash/shell.cc b/ash/shell.cc |
| index b8a69de6cc396d169978dac6e2a6a0f79cb2fb62..275bfcd431db0db99c39010f805072ab56d3dad1 100644 |
| --- a/ash/shell.cc |
| +++ b/ash/shell.cc |
| @@ -465,21 +465,9 @@ void Shell::RemoveShellObserver(ShellObserver* observer) { |
| observers_.RemoveObserver(observer); |
| } |
| -void Shell::EnableMaximizeModeWindowManager(bool enable) { |
| - if (enable && !maximize_mode_window_manager_.get()) { |
| - maximize_mode_window_manager_.reset(new MaximizeModeWindowManager()); |
| - } else if (!enable && maximize_mode_window_manager_.get()) { |
| - maximize_mode_window_manager_.reset(); |
| - } |
| -} |
| - |
| -bool Shell::IsMaximizeModeWindowManagerEnabled() { |
| - return maximize_mode_window_manager_.get() != NULL; |
| -} |
| - |
| #if defined(OS_CHROMEOS) |
| bool Shell::ShouldSaveDisplaySettings() { |
| - return !((IsMaximizeModeWindowManagerEnabled() && |
| + return !((maximize_mode_controller_->IsMaximizeModeWindowManagerEnabled() && |
| maximize_mode_controller_->in_set_screen_rotation()) || |
| resolution_notification_controller_->DoesNotificationTimeout()); |
| } |
| @@ -691,8 +679,8 @@ Shell::~Shell() { |
| // Destroy maximize window manager early on since it has some observers which |
| // need to be removed. |
| + maximize_mode_controller_->EnableMaximizeModeWindowManager(false); |
|
flackr
2014/05/29 16:10:06
This should be implicit/automatic by destructing t
jonross
2014/05/29 17:40:00
Creating a shutdown method on the controller.
We n
|
| maximize_mode_controller_.reset(); |
| - maximize_mode_window_manager_.reset(); |
| // AppList needs to be released before shelf layout manager, which is |
| // destroyed with shelf container in the loop below. However, app list |