Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/heap_map.dart

Issue 308673012: Redo LocationManager to use HTML5 History API (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
diff --git a/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart b/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
index 6688e5a3da56f2306069a136430e91e7cdc0e084..4983fba597a91979eb25ea295fe997e145ce42ff 100644
--- a/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
+++ b/runtime/bin/vmservice/client/lib/src/elements/heap_map.dart
@@ -92,13 +92,13 @@ class HeapMapElement extends ObservatoryElement {
void _updateClassList(classList, int freeClassId) {
for (var member in classList['members']) {
- if (member['type'] != '@Class') {
+ if (member is! Class) {
Logger.root.info('$member');
continue;
}
- var classId = int.parse(member['id'].split('/').last);
+ var classId = int.parse(member.id.split('/').last);
var color = _classIdToRGBA(classId);
- _addClass(classId, member['name'], color);
+ _addClass(classId, member.name, color);
}
_addClass(freeClassId, 'Free', _freeColor);
_addClass(0, '', _pageSeparationColor);
@@ -148,7 +148,7 @@ class HeapMapElement extends ObservatoryElement {
var className = _classNameAt(event.offset);
status = (className == '') ? '-' : '$className $addressString';
}
-
+
void _handleClick(MouseEvent event) {
var address = _objectAt(event.offset).address.toRadixString(16);
window.location.hash = "/${fragmentation.isolate.link}/address/$address";

Powered by Google App Engine
This is Rietveld 408576698