Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9072)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc

Issue 308673011: Remove the override BookmarkBarView::HitTestRect() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
index fda8b77ab11f0a40ffc4c2459e1c69fedf37d210..34e390620cc5704bc437fe9eb7d598898c237678 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc
@@ -679,17 +679,17 @@ gfx::Size BookmarkBarView::GetPreferredSize() const {
return prefsize;
}
-bool BookmarkBarView::HitTestRect(const gfx::Rect& rect) const {
- // If bookmark bar is attached and omnibox popup is open (on top of the bar),
- // force hit-testing to fail. This prevents hovers/clicks just above the
- // omnibox popup from activating the top few pixels of items on the bookmark
- // bar.
+bool BookmarkBarView::CanProcessEventsWithinSubtree() const {
+ // If the bookmark bar is attached and the omnibox popup is open (on top of
+ // the bar), prevent events from targeting the bookmark bar or any of its
+ // descendants. This will prevent hovers/clicks just above the omnibox popup
+ // from activating the top few pixels of items on the bookmark bar.
if (!IsDetached() && browser_view_ &&
browser_view_->GetLocationBar()->GetOmniboxView()->model()->
popup_model()->IsOpen()) {
return false;
}
- return DetachableToolbarView::HitTestRect(rect);
+ return true;
}
gfx::Size BookmarkBarView::GetMinimumSize() const {
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698