Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 308673011: Remove the override BookmarkBarView::HitTestRect() (Closed)

Created:
6 years, 6 months ago by tdanderson
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Remove the override BookmarkBarView::HitTestRect() The logic in BookmarkBarView::HitTestRect() does not depend on |rect| and only has the purpose of preventing or allowing event-targeting of itself or its descendants. For this reason, the logic belongs in an override of CanProcessEventsWithinSubtree() instead of HitTestRect(). BUG=374340 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274372

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tdanderson
Scott, can you please take a look?
6 years, 6 months ago (2014-06-02 18:19:45 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-02 19:19:25 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 6 months ago (2014-06-02 19:20:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdanderson@chromium.org/308673011/1
6 years, 6 months ago (2014-06-02 19:22:41 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 22:02:45 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 23:51:27 UTC) #6
Message was sent while issue was closed.
Change committed as 274372

Powered by Google App Engine
This is Rietveld 408576698