Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 308663002: Pepper: Move several tests to content_browsertests. (Closed)

Created:
6 years, 6 months ago by teravest
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Pepper: Move several tests to content_browsertests. This moves a bunch of non-NaCl pepper tests to browser_tests. I moved a bunch of the ones that looked easiest here, and more will be moved over in follow-on changes. BUG=371873 R=dmichael@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273494

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -77 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 7 chunks +0 lines, -77 lines 2 comments Download
M content/test/ppapi/ppapi_browsertest.cc View 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
teravest
6 years, 6 months ago (2014-05-29 15:53:42 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/308663002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc File chrome/test/ppapi/ppapi_browsertest.cc (left): https://codereview.chromium.org/308663002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc#oldcode230 chrome/test/ppapi/ppapi_browsertest.cc:230: } ^^^ What's the reasoning behind leaving these ...
6 years, 6 months ago (2014-05-29 16:04:47 UTC) #2
teravest
https://codereview.chromium.org/308663002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc File chrome/test/ppapi/ppapi_browsertest.cc (left): https://codereview.chromium.org/308663002/diff/1/chrome/test/ppapi/ppapi_browsertest.cc#oldcode230 chrome/test/ppapi/ppapi_browsertest.cc:230: } On 2014/05/29 16:04:47, dmichael wrote: > ^^^ What's ...
6 years, 6 months ago (2014-05-29 16:07:16 UTC) #3
teravest
The CQ bit was checked by teravest@chromium.org
6 years, 6 months ago (2014-05-29 16:07:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/308663002/1
6 years, 6 months ago (2014-05-29 16:09:15 UTC) #5
teravest
6 years, 6 months ago (2014-05-29 16:34:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r273494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698