Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 308643004: changed MSAP to work with 96000KHZ (Closed)

Created:
6 years, 6 months ago by no longer working on chromium
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

changed MSAP to work with 96000KHZ. The problem why it did not work is that the FIFO used in MSAP has a size smaller than 10ms buffer before, so it crashed before webrtc::AudioProcessing consumes it. FYI, previously the APM in Chrome was only enabled for finch experiment on Canary, so the problem does not occur in stable and beta. And I recently enabled it as default. BUG=378895 TEST= use 96000KHz as sample rate, go to apprtc.appspot.com/?&debug=loopback to make a call. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274216

Patch Set 1 #

Patch Set 2 : added unittest #

Total comments: 2

Patch Set 3 : addressed the comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -7 lines) Patch
M content/renderer/media/media_stream_audio_processor.cc View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 1 4 chunks +38 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
no longer working on chromium
Henrik, could you please review this small fix? Thanks SX
6 years, 6 months ago (2014-05-30 15:07:30 UTC) #1
no longer working on chromium
Added unittest to verify MSAP works with all supported sample rates. lg now?
6 years, 6 months ago (2014-05-30 15:52:37 UTC) #2
henrika (OOO until Aug 14)
LGTM w/ nit. https://codereview.chromium.org/308643004/diff/40001/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/308643004/diff/40001/content/renderer/media/media_stream_audio_processor.cc#newcode74 content/renderer/media/media_stream_audio_processor.cc:74: // Also, FIFO needs to have ...
6 years, 6 months ago (2014-06-02 08:23:40 UTC) #3
no longer working on chromium
Thanks Henrik. Landing soon. https://codereview.chromium.org/308643004/diff/40001/content/renderer/media/media_stream_audio_processor.cc File content/renderer/media/media_stream_audio_processor.cc (right): https://codereview.chromium.org/308643004/diff/40001/content/renderer/media/media_stream_audio_processor.cc#newcode74 content/renderer/media/media_stream_audio_processor.cc:74: // Also, FIFO needs to ...
6 years, 6 months ago (2014-06-02 09:15:07 UTC) #4
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 6 months ago (2014-06-02 09:15:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/308643004/60001
6 years, 6 months ago (2014-06-02 09:15:46 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 12:40:14 UTC) #7
Message was sent while issue was closed.
Change committed as 274216

Powered by Google App Engine
This is Rietveld 408576698