Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1246)

Unified Diff: Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js

Issue 308643003: DevTools: [JSDoc] Avoid partial arg list annotations in the "profiler" module (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
diff --git a/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js b/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
index 98db45948e2a1593588b9597a9d07abff5a2b301..4869cf2bda50b39d4fd4fbc9580a6e3bc0d420f4 100644
--- a/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
+++ b/Source/devtools/front_end/profiler/heap_snapshot_worker/HeapSnapshot.js
@@ -729,6 +729,7 @@ WebInspector.HeapSnapshotIndexRangeIterator.prototype = {
* @constructor
* @implements {WebInspector.HeapSnapshotItemIterator}
* @param {!WebInspector.HeapSnapshotItemIterator} iterator
+ * @param {function(!WebInspector.HeapSnapshotItem):boolean=} filter
*/
WebInspector.HeapSnapshotFilteredIterator = function(iterator, filter)
{
@@ -811,6 +812,7 @@ WebInspector.HeapSnapshotProgress.prototype = {
/**
+ * @param {!Object} profile
* @param {!WebInspector.HeapSnapshotProgress} progress
* @param {boolean} showHiddenData
* @constructor
@@ -1897,6 +1899,7 @@ WebInspector.HeapSnapshot.prototype = {
/**
* @param {number} nodeIndex
+ * @param {?function(!WebInspector.HeapSnapshotEdge):boolean} filter
* @return {!WebInspector.HeapSnapshotEdgesProvider}
*/
createEdgesProviderForTest: function(nodeIndex, filter)
@@ -2089,14 +2092,16 @@ WebInspector.HeapSnapshotItemProvider.prototype = {
/**
* @constructor
* @extends {WebInspector.HeapSnapshotItemProvider}
+ * @param {!WebInspector.HeapSnapshot} snapshot
+ * @param {?function(!WebInspector.HeapSnapshotEdge):boolean} filter
+ * @param {!WebInspector.HeapSnapshotEdgeIterator} edgesIter
* @param {!WebInspector.HeapSnapshotItemIndexProvider} indexProvider
*/
WebInspector.HeapSnapshotEdgesProvider = function(snapshot, filter, edgesIter, indexProvider)
{
this.snapshot = snapshot;
- if (filter)
- edgesIter = new WebInspector.HeapSnapshotFilteredIterator(edgesIter, filter);
- WebInspector.HeapSnapshotItemProvider.call(this, edgesIter, indexProvider);
+ var iter = filter ? new WebInspector.HeapSnapshotFilteredIterator(edgesIter, /** @type {function(!WebInspector.HeapSnapshotItem):boolean} */ (filter)) : edgesIter;
+ WebInspector.HeapSnapshotItemProvider.call(this, iter, indexProvider);
}
WebInspector.HeapSnapshotEdgesProvider.prototype = {
@@ -2188,6 +2193,7 @@ WebInspector.HeapSnapshotEdgesProvider.prototype = {
/**
* @constructor
* @extends {WebInspector.HeapSnapshotItemProvider}
+ * @param {!WebInspector.HeapSnapshot} snapshot
* @param {?function(!WebInspector.HeapSnapshotNode):boolean} filter
* @param {(!Array.<number>|!Uint32Array)} nodeIndexes
*/
@@ -2196,8 +2202,9 @@ WebInspector.HeapSnapshotNodesProvider = function(snapshot, filter, nodeIndexes)
this.snapshot = snapshot;
var indexProvider = new WebInspector.HeapSnapshotNodeIndexProvider(snapshot);
var it = new WebInspector.HeapSnapshotIndexRangeIterator(indexProvider, nodeIndexes);
+
if (filter)
- it = new WebInspector.HeapSnapshotFilteredIterator(it, filter);
+ it = new WebInspector.HeapSnapshotFilteredIterator(it, /** @type {function(!WebInspector.HeapSnapshotItem):boolean} */ (filter));
WebInspector.HeapSnapshotItemProvider.call(this, it, indexProvider);
}
@@ -2270,6 +2277,7 @@ WebInspector.HeapSnapshotNodesProvider.prototype = {
},
/**
+ * @param {!WebInspector.HeapSnapshotCommon.ComparatorConfig} comparator
* @param {number} leftBound
* @param {number} rightBound
* @param {number} windowLeft

Powered by Google App Engine
This is Rietveld 408576698