Source/devtools/front_end/profiler/HeapSnapshotView.js - Issue 308643003: DevTools: [JSDoc] Avoid partial arg list annotations in the "profiler" module

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/profiler/HeapSnapshotView.js

Issue 308643003: DevTools: [JSDoc] Avoid partial arg list annotations in the "profiler" module (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/profiler/HeapSnapshotProxy.js ('k') | Source/devtools/front_end/profiler/ProfileLauncherView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/profiler/HeapSnapshotView.js

diff --git a/Source/devtools/front_end/profiler/HeapSnapshotView.js b/Source/devtools/front_end/profiler/HeapSnapshotView.js

index c8dc7be17e1f70e21fb9e72df73346bac160485a..46ba23ae7ecab4a659195d46b27e4e96cc3f2ecb 100644

--- a/Source/devtools/front_end/profiler/HeapSnapshotView.js

+++ b/Source/devtools/front_end/profiler/HeapSnapshotView.js

@@ -1744,6 +1744,7 @@ WebInspector.HeapSnapshotLoadFromFileDelegate.prototype = {

/**

* @param {!WebInspector.ChunkedReader} reader

+ * @param {?Event} e

onError: function (reader, e)

{

@@ -1795,10 +1796,11 @@ WebInspector.SaveSnapshotOutputStreamDelegate.prototype = {

/**

* @param {!WebInspector.ChunkedReader} reader

+ * @param {?Event} event

onError: function(reader, event)

{

- WebInspector.messageSink.addErrorMessage("Failed to read heap snapshot from temp file: " + event.message);

+ WebInspector.messageSink.addErrorMessage("Failed to read heap snapshot from temp file: " + /** @type {!ErrorEvent} */ (event).message);

this.onTransferFinished();

}