LayoutTests/svg/as-image/svg-as-image-intrinsic-size.html - Issue 308643002: Teach SVGImage::containerSize() to deduce intrinsic values

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/as-image/svg-as-image-intrinsic-size.html

Issue 308643002: Teach SVGImage::containerSize() to deduce intrinsic values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-text-zoom-factor

Patch Set: computeIntrinsicRatioInformation does not always write to intrinsicRatio; take care to init it Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/css3/compositing/background-blend-mode-svg-color.html ('K') | « LayoutTests/svg/as-image/resources/link.svg ('k') | Source/core/svg/graphics/SVGImage.cpp » ('j') | Source/core/svg/graphics/SVGImage.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Test that intrinsic height can be resolved</title>

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <img src="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' width='300' viewBox='0 180 150 220' style='background:blue'></svg>">

	6 <img src="data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' height='440 ' viewBox='0 180 150 220' style='background:purple'></svg>">

	7 <script>

	8 var imgs = document.getElementsByTagName('img');

	9 function waitForComplete(img, i) {

	10 if (img.complete) {

	11 assert_equals(img.width, 300);

	12 assert_equals(img.height, 440);

	13 this.done();

	14 } else {

	15 setTimeout(t.step_func(waitForComplete.bind(this, img, i + 1)), 10);
	pdr. 2014/06/06 03:54:50 10!!1!? Lets crank this down to 1ms :) 10!!1!? Lets crank this down to 1ms :) davve 2014/06/06 20:26:26 Sure. (I'm hoping it doesn't matter in practice si Show quoted text On 2014/06/06 03:54:50, pdr wrote: > 10!!1!? Lets crank this down to 1ms :) Sure. (I'm hoping it doesn't matter in practice since the first branch will be hit (it's a short data uri after all))
	16 }

	17 }

	18

	19 var t1 = async_test("Test that intrinsic height can be calculated from intrins ic width and intrinsic ratio");

	20 t1.step(waitForComplete.bind(t1, imgs[0], 0));

	21

	22 var t2 = async_test("Test that intrinsic width can be calculated from intrinsi c height and intrinsic ratio");

	23 t2.step(waitForComplete.bind(t2, imgs[1], 0));

	24 </script>

OLD	NEW