Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: Source/devtools/front_end/ResponsiveDesignView.js

Issue 308633003: DevTools: do not update ui on every warning update. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/ResponsiveDesignView.js
diff --git a/Source/devtools/front_end/ResponsiveDesignView.js b/Source/devtools/front_end/ResponsiveDesignView.js
index 4883275c38c87777eb39dbbb6a3acacaac5aa1ed..da221f4ebff4591127f0b2720abb1fa34027a88d 100644
--- a/Source/devtools/front_end/ResponsiveDesignView.js
+++ b/Source/devtools/front_end/ResponsiveDesignView.js
@@ -454,13 +454,15 @@ WebInspector.ResponsiveDesignView.prototype = {
fieldsetElement.appendChild(WebInspector.SettingsUI.createSettingCheckbox(WebInspector.UIString("Viewport"), WebInspector.overridesSupport.settings.emulateViewport, true));
// Warning
- this._warningMessage = this._responsiveDesignContainer.element.createChild("div", "responsive-design-warning");
+ this._warningMessage = this._responsiveDesignContainer.element.createChild("div", "responsive-design-warning hidden");
WebInspector.overridesSupport.addEventListener(WebInspector.OverridesSupport.Events.OverridesWarningUpdated, this._overridesWarningUpdated, this);
},
_overridesWarningUpdated: function()
{
var message = WebInspector.overridesSupport.warningMessage();
+ if (this._warningMessage.textContent === message)
+ return;
this._warningMessage.classList.toggle("hidden", !message);
this._warningMessage.textContent = message;
this._responsiveDesignModeChanged();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698