Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 308623002: Initialize IMF with a whitelist of input methods so that login screen doesn't need to wait for comp… (Closed)

Created:
6 years, 6 months ago by Shu Chen
Modified:
6 years, 6 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org, Alexander Alekseev, Nikita (slow), Dmitry Polukhin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Initialize IMF with a whitelist of input methods so that login screen doesn't need to wait for component extension loading. BUG=377987 TEST=Verified on Pixel device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273753

Patch Set 1 #

Total comments: 2

Patch Set 2 : debugging... #

Patch Set 3 : add logs for debugging... #

Patch Set 4 : fixed unit tests. #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 3 4 2 chunks +15 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 1 2 3 4 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Shu Chen
Nona, can you please review this cl? Thanks
6 years, 6 months ago (2014-05-29 06:37:23 UTC) #1
Seigo Nonaka
lgmt, please feel free to submit after addressing my comment. https://codereview.chromium.org/308623002/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl.cc File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/308623002/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl.cc#newcode63 ...
6 years, 6 months ago (2014-05-29 06:53:39 UTC) #2
Seigo Nonaka
lgtm :)
6 years, 6 months ago (2014-05-29 06:53:56 UTC) #3
Shu Chen
https://codereview.chromium.org/308623002/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl.cc File chrome/browser/chromeos/input_method/input_method_manager_impl.cc (right): https://codereview.chromium.org/308623002/diff/1/chrome/browser/chromeos/input_method/input_method_manager_impl.cc#newcode63 chrome/browser/chromeos/input_method/input_method_manager_impl.cc:63: util_(delegate_.get(), whitelist_.GetSupportedInputMethods()), On 2014/05/29 06:53:39, Seigo Nonaka wrote: > ...
6 years, 6 months ago (2014-05-29 07:15:27 UTC) #4
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-05-29 07:15:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/308623002/1
6 years, 6 months ago (2014-05-29 07:16:24 UTC) #6
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-05-30 03:22:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/308623002/50001
6 years, 6 months ago (2014-05-30 03:25:42 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 07:28:58 UTC) #9
Message was sent while issue was closed. 
Change committed as 273753

Powered by Google App Engine
This is Rietveld 408576698