Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3365)

Unified Diff: base/files/file.h

Issue 308613002: [fsp] Convert base::File::Error to string. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleaned up. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/files/file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file.h
diff --git a/base/files/file.h b/base/files/file.h
index f1a83774becfa65649cf23913363d59db7cd92c9..ae915d6fb71e8b060ce0bfede1f8cb921c6f1661 100644
--- a/base/files/file.h
+++ b/base/files/file.h
@@ -5,6 +5,8 @@
#ifndef BASE_FILES_FILE_H_
#define BASE_FILES_FILE_H_
+#include <string>
rvargas (doing something else) 2014/05/29 19:07:27 nit: This should go after <windows> and <sys/stat.
mtomasz 2014/05/30 00:25:55 Done.
+
#include "build/build_config.h"
#if defined(OS_WIN)
#include <windows.h>
@@ -289,6 +291,9 @@ class BASE_EXPORT File {
static Error OSErrorToFileError(int saved_errno);
#endif
+ // Converts an error value to a human-readable form. Used for logging.
+ static std::string ErrorToString(Error error);
+
private:
void SetPlatformFile(PlatformFile file);
« no previous file with comments | « no previous file | base/files/file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698