Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 308613002: [fsp] Convert base::File::Error to string. (Closed)

Created:
6 years, 6 months ago by mtomasz
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

[fsp] Convert base::File::Error to string. This patch adds a utility function which converts a base::File::Error code to a human readable form. It will be used for logging request errors in the File System Provider API. TEST=Not used yet. BUG=376095 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273779

Patch Set 1 #

Patch Set 2 : Cleaned up. #

Total comments: 2

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M base/files/file.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M base/files/file.cc View 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mtomasz
@rvargas: PTAL. Thanks.
6 years, 6 months ago (2014-05-29 06:29:32 UTC) #1
rvargas (doing something else)
LGTM after the nit. https://codereview.chromium.org/308613002/diff/20001/base/files/file.h File base/files/file.h (right): https://codereview.chromium.org/308613002/diff/20001/base/files/file.h#newcode8 base/files/file.h:8: #include <string> nit: This should ...
6 years, 6 months ago (2014-05-29 19:07:27 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 6 months ago (2014-05-30 00:25:41 UTC) #3
mtomasz
https://codereview.chromium.org/308613002/diff/20001/base/files/file.h File base/files/file.h (right): https://codereview.chromium.org/308613002/diff/20001/base/files/file.h#newcode8 base/files/file.h:8: #include <string> On 2014/05/29 19:07:27, rvargas wrote: > nit: ...
6 years, 6 months ago (2014-05-30 00:25:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/308613002/40001
6 years, 6 months ago (2014-05-30 00:27:23 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-05-30 05:07:47 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 10:07:32 UTC) #7
Message was sent while issue was closed.
Change committed as 273779

Powered by Google App Engine
This is Rietveld 408576698