|
|
Chromium Code Reviews|
Created:
6 years, 6 months ago by tkent Modified:
6 years, 6 months ago CC:
blink-reviews, Erik Corry, Mikhail Base URL:
svn://svn.chromium.org/blink/trunk Visibility:
Public. |
DescriptionFix a race in DatabaseManager::manager.
DatabaseManager::manager should return a singleton of DatabaseManager. However
it had no mutex. It was possible to create two DatabaseManager.
BUG=378250
NOTRY=true
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175057
Patch Set 1 : #
Total comments: 1
Messages
Total messages: 17 (0 generated)
lgtm https://codereview.chromium.org/308593004/diff/20001/Source/modules/webdataba... File Source/modules/webdatabase/DatabaseManager.cpp (right): https://codereview.chromium.org/308593004/diff/20001/Source/modules/webdataba... Source/modules/webdatabase/DatabaseManager.cpp:52: AtomicallyInitializedStatic(DatabaseManager*, dbManager = new DatabaseManager); I didn't know this existed, crazy. https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
LGTM
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...) linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/9923)
The CQ bit was unchecked by tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
The CQ bit was unchecked by tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9689)
The CQ bit was unchecked by tkent@chromium.org
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
Message was sent while issue was closed.
Change committed as 175057 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
