Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 308593004: Fix a race in DatabaseManager::manager. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
CC:
blink-reviews, Erik Corry, Mikhail
Visibility:
Public.

Description

Fix a race in DatabaseManager::manager. DatabaseManager::manager should return a singleton of DatabaseManager. However it had no mutex. It was possible to create two DatabaseManager. BUG=378250 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175057

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M Source/modules/webdatabase/DatabaseManager.cpp View 1 chunk +1 line, -6 lines 1 comment Download

Messages

Total messages: 17 (0 generated)
tkent
6 years, 6 months ago (2014-05-29 07:01:26 UTC) #1
eseidel
lgtm https://codereview.chromium.org/308593004/diff/20001/Source/modules/webdatabase/DatabaseManager.cpp File Source/modules/webdatabase/DatabaseManager.cpp (right): https://codereview.chromium.org/308593004/diff/20001/Source/modules/webdatabase/DatabaseManager.cpp#newcode52 Source/modules/webdatabase/DatabaseManager.cpp:52: AtomicallyInitializedStatic(DatabaseManager*, dbManager = new DatabaseManager); I didn't know ...
6 years, 6 months ago (2014-05-29 07:03:37 UTC) #2
haraken
LGTM
6 years, 6 months ago (2014-05-29 07:05:01 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-05-29 07:36:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
6 years, 6 months ago (2014-05-29 07:37:25 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-29 08:10:21 UTC) #6
tkent
The CQ bit was unchecked by tkent@chromium.org
6 years, 6 months ago (2014-05-29 12:35:50 UTC) #7
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-05-29 12:35:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
6 years, 6 months ago (2014-05-29 12:36:15 UTC) #9
tkent
The CQ bit was unchecked by tkent@chromium.org
6 years, 6 months ago (2014-05-29 14:15:09 UTC) #10
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-05-29 14:15:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
6 years, 6 months ago (2014-05-29 14:15:55 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-29 14:43:19 UTC) #13
tkent
The CQ bit was unchecked by tkent@chromium.org
6 years, 6 months ago (2014-05-29 14:45:10 UTC) #14
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-05-29 14:45:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/308593004/20001
6 years, 6 months ago (2014-05-29 14:46:19 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 14:47:10 UTC) #17
Message was sent while issue was closed.
Change committed as 175057

Powered by Google App Engine
This is Rietveld 408576698