Issue 308583002: [Mac] Implement frame.[color|inactiveColor].

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 308583002: [Mac] Implement frame.[color|inactiveColor]. (Closed)

Created:
6 years, 6 months ago by jackhou1

Modified:
6 years, 6 months ago

Reviewers:
tapted

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@custom_frame_view

Visibility:
Public.

[Mac] Implement frame.[color|inactiveColor]. This also removes --apps-use-native-frame. This is a second attempt at https://codereview.chromium.org/251993002/. There was an underlying bug which caused crashes on 10.7 when native frames are enabled (http://crbug.com/378581). It's fixed by https://codereview.chromium.org/307843002/. BUG=339558 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274084

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -31 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm	View	1	8 chunks	+36 lines, -14 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/308583002/20001

6 years, 6 months ago (2014-05-31 02:57:05 UTC) #4

Message was sent while issue was closed.

Change committed as 274084