Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: chrome/browser/media/encrypted_media_browsertest.cc

Issue 308553002: Integrate browser tests with new EME player. (Closed) Base URL: http://git.chromium.org/chromium/src.git@eme_player
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/media_browsertest.cc » ('j') | chrome/test/data/media/eme_player.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/encrypted_media_browsertest.cc
diff --git a/chrome/browser/media/encrypted_media_browsertest.cc b/chrome/browser/media/encrypted_media_browsertest.cc
index 875a00389b7fd9a5057816d0db8226856453f2a6..7588b2bb663f70b58f12c5d20649d8e2d745a8d3 100644
--- a/chrome/browser/media/encrypted_media_browsertest.cc
+++ b/chrome/browser/media/encrypted_media_browsertest.cc
@@ -64,9 +64,11 @@ const char kLoadableSession[] = "LoadableSession";
const char kUnknownSession[] = "UnknownSession";
// EME-specific test results and errors.
-const char kEmeKeyError[] = "KEYERROR";
+const char kEmeKeyError[] = "KEY_ERROR";
const char kEmeNotSupportedError[] = "NOTSUPPORTEDERROR";
-const char kFileIOTestSuccess[] = "FILEIOTESTSUCCESS";
+const char kFileIOTestSuccess[] = "FILE_IO_TEST_SUCCESS";
+
+const char kDefaultEMEPlayer[] = "eme_player.html";
ddorwin 2014/05/30 17:42:56 "Eme"
shadi 2014/05/31 00:31:37 Done.
// The type of video src used to load media.
enum SrcType {
@@ -167,7 +169,7 @@ class EncryptedMediaTestBase : public MediaBrowserTest {
if (!IsPlayBackPossible(key_system))
expected_title = kEmeKeyError;
- RunEncryptedMediaTest("encrypted_media_player.html",
+ RunEncryptedMediaTest(kDefaultEMEPlayer,
media_file,
media_type,
key_system,
@@ -308,7 +310,7 @@ class ECKEncryptedMediaTest : public EncryptedMediaTestBase {
const std::string& expected_title) {
// Since we do not test playback, arbitrarily choose a test file and source
// type.
- RunEncryptedMediaTest("encrypted_media_player.html",
+ RunEncryptedMediaTest(kDefaultEMEPlayer,
"bear-a-enc_a.webm",
kWebMAudioOnly,
key_system,
@@ -375,7 +377,7 @@ class EncryptedMediaTest
}
void RunInvalidResponseTest() {
- RunEncryptedMediaTest("encrypted_media_player.html",
+ RunEncryptedMediaTest(kDefaultEMEPlayer,
"bear-320x240-av-enc_av.webm",
kWebMAudioVideo,
CurrentKeySystem(),
@@ -591,7 +593,7 @@ IN_PROC_BROWSER_TEST_P(EncryptedMediaTest, Playback_AudioOnly_MP4) {
#if defined(WIDEVINE_CDM_AVAILABLE)
// The parent key system cannot be used in generateKeyRequest.
IN_PROC_BROWSER_TEST_F(WVEncryptedMediaTest, ParentThrowsException_Prefixed) {
- RunEncryptedMediaTest("encrypted_media_player.html",
+ RunEncryptedMediaTest(kDefaultEMEPlayer,
"bear-a-enc_a.webm",
kWebMAudioOnly,
"com.widevine",
@@ -605,7 +607,7 @@ IN_PROC_BROWSER_TEST_F(WVEncryptedMediaTest, ParentThrowsException_Prefixed) {
// TODO(jrummell): http://crbug.com/349181
// The parent key system cannot be used when creating MediaKeys.
IN_PROC_BROWSER_TEST_F(WVEncryptedMediaTest, ParentThrowsException) {
- RunEncryptedMediaTest("encrypted_media_player.html",
+ RunEncryptedMediaTest(kDefaultEMEPlayer,
"bear-a-enc_a.webm",
kWebMAudioOnly,
"com.widevine",
@@ -642,7 +644,7 @@ IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, FileIOTest) {
}
IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, LoadLoadableSession) {
- RunEncryptedMediaTest("encrypted_media_player.html",
+ RunEncryptedMediaTest(kDefaultEMEPlayer,
"bear-320x240-v-enc_v.webm",
kWebMVideoOnly,
kExternalClearKeyKeySystem,
@@ -655,7 +657,7 @@ IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, LoadLoadableSession) {
IN_PROC_BROWSER_TEST_F(ECKEncryptedMediaTest, LoadUnknownSession) {
// TODO(xhwang): Add a specific error for this failure, e.g. kSessionNotFound.
- RunEncryptedMediaTest("encrypted_media_player.html",
+ RunEncryptedMediaTest(kDefaultEMEPlayer,
"bear-320x240-v-enc_v.webm",
kWebMVideoOnly,
kExternalClearKeyKeySystem,
« no previous file with comments | « no previous file | chrome/browser/media/media_browsertest.cc » ('j') | chrome/test/data/media/eme_player.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698