Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 308543002: Support for YUV 4:4:4 subsampling in vpx decoder. (Closed)

Created:
6 years, 6 months ago by sandersd (OOO until July 31)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, ericde
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Support for YUV 4:4:4 subsampling in vpx decoder. Depends on https://codereview.chromium.org/289373011/. BUG=104711 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274747

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add pipeline inetegration test. #

Patch Set 3 : Remove binary data. #

Patch Set 4 : Typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -14 lines) Patch
M media/filters/pipeline_integration_test.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 2 3 2 chunks +26 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
sandersd (OOO until July 31)
6 years, 6 months ago (2014-05-29 00:35:15 UTC) #1
scherkus (not reviewing)
can you get a VP9 444 copy of our bear video + a pipeline integration ...
6 years, 6 months ago (2014-05-29 02:30:26 UTC) #2
sandersd (OOO until July 31)
I've added a test clip, but you should be aware that the bitstream format isn't ...
6 years, 6 months ago (2014-05-29 20:39:09 UTC) #3
scherkus (not reviewing)
lgtm you'll likely need to get someone to force-commit the .webm file as CQ doesn't ...
6 years, 6 months ago (2014-05-29 20:42:33 UTC) #4
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 6 months ago (2014-06-03 21:08:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/308543002/40001
6 years, 6 months ago (2014-06-03 21:10:29 UTC) #6
sandersd (OOO until July 31)
The CQ bit was checked by sandersd@chromium.org
6 years, 6 months ago (2014-06-03 22:50:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sandersd@chromium.org/308543002/60001
6 years, 6 months ago (2014-06-03 22:51:28 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 09:26:26 UTC) #9
Message was sent while issue was closed.
Change committed as 274747

Powered by Google App Engine
This is Rietveld 408576698