Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: runtime/lib/object.cc

Issue 308513005: Intrinsify [] for ExternalUint8 and Uint8 typed data. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/intrinsifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/object.cc
===================================================================
--- runtime/lib/object.cc (revision 36830)
+++ runtime/lib/object.cc (working copy)
@@ -162,15 +162,16 @@
DEFINE_NATIVE_ENTRY(Object_instanceOf, 5) {
- const Instance& instance = Instance::CheckedHandle(arguments->NativeArgAt(0));
+ const Instance& instance =
+ Instance::CheckedHandle(isolate, arguments->NativeArgAt(0));
// Instantiator at position 1 is not used. It is passed along so that the call
// can be easily converted to an optimized implementation. Instantiator is
// used to populate the subtype cache.
const TypeArguments& instantiator_type_arguments =
- TypeArguments::CheckedHandle(arguments->NativeArgAt(2));
+ TypeArguments::CheckedHandle(isolate, arguments->NativeArgAt(2));
const AbstractType& type =
- AbstractType::CheckedHandle(arguments->NativeArgAt(3));
- const Bool& negate = Bool::CheckedHandle(arguments->NativeArgAt(4));
+ AbstractType::CheckedHandle(isolate, arguments->NativeArgAt(3));
+ const Bool& negate = Bool::CheckedHandle(isolate, arguments->NativeArgAt(4));
ASSERT(type.IsFinalized());
ASSERT(!type.IsMalformed());
ASSERT(!type.IsMalbounded());
@@ -180,7 +181,7 @@
WarnOnJSIntegralNumTypeTest(instance, instantiator_type_arguments, type);
}
- Error& bound_error = Error::Handle();
+ Error& bound_error = Error::Handle(isolate, Error::null());
const bool is_instance_of = instance.IsInstanceOf(type,
instantiator_type_arguments,
&bound_error);
@@ -202,7 +203,7 @@
ASSERT(caller_frame != NULL);
const intptr_t location = caller_frame->GetTokenPos();
String& bound_error_message = String::Handle(
- String::New(bound_error.ToErrorCString()));
+ isolate, String::New(bound_error.ToErrorCString()));
Exceptions::CreateAndThrowTypeError(
location, Symbols::Empty(), Symbols::Empty(),
Symbols::Empty(), bound_error_message);
« no previous file with comments | « no previous file | runtime/vm/intrinsifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698