Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tests/standalone/typed_data_test.dart

Issue 308513005: Intrinsify [] for ExternalUint8 and Uint8 typed data. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/vm/intrinsifier_mips.cc ('K') | « runtime/vm/intrinsifier_x64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/typed_data_test.dart
===================================================================
--- tests/standalone/typed_data_test.dart (revision 36816)
+++ tests/standalone/typed_data_test.dart (working copy)
@@ -60,6 +60,8 @@
typed_data[1] = 1.2;
});
}
+ Expect.throws(() => typed_data[-1]);
+ Expect.throws(() => typed_data[100]);
zra 2014/05/30 18:11:00 Is the non-smi index path followed somewhere?
srdjan 2014/05/30 19:23:12 Done.
}
void testUnsignedTypedDataRange(bool check_throws) {
@@ -87,6 +89,8 @@
typed_data[1] = 1.2;
});
}
+ Expect.throws(() => typed_data[-1]);
+ Expect.throws(() => typed_data[100]);
}
void testClampedUnsignedTypedDataRangeHelper(Uint8ClampedList typed_data,
« runtime/vm/intrinsifier_mips.cc ('K') | « runtime/vm/intrinsifier_x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698