Intrinsify [] for ExternalUint8 and Uint8 typed data.

runtime/vm/intrinsifier_arm64.cc

Index: runtime/vm/intrinsifier_arm64.cc
===================================================================
--- runtime/vm/intrinsifier_arm64.cc	(revision 36816)
+++ runtime/vm/intrinsifier_arm64.cc	(working copy)
@@ -354,6 +354,52 @@
 }
 
 
+void Intrinsifier::Uint8Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+  __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
+  __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
+  __ tsti(R0, kSmiTagMask);
+  __ b(&fall_through, NE);  // Index is not a smi, fall through.
+
+  // Range check.
+  __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
+  __ cmp(R0, Operand(R6));
+  __ b(&fall_through, CS);
+
+  // Array element at R1 + R0 + TypedData::data_offset - 1.
+  // Untag R0;

[zra, 2014/05/30 18:11:00]

; -> .

[srdjan, 2014/05/30 19:23:12]

Done.

+  __ add(R1, R1, Operand(R0, LSR, 1));
+  __ ldr(R0, FieldAddress(R1, TypedData::data_offset()), kUnsignedByte);
+  __ SmiTag(R0);
+  __ ret();
+  __ Bind(&fall_through);
+}
+
+
+void Intrinsifier::ExternalUint8Array_getIndexed(Assembler* assembler) {
+  Label fall_through;
+
+  __ ldr(R0, Address(SP, + 0 * kWordSize));  // Index.
+  __ ldr(R1, Address(SP, + 1 * kWordSize));  // Array.
+  __ tsti(R0, kSmiTagMask);
+  __ b(&fall_through, NE);  // Index is not a smi, fall through.
+
+  // Range check.
+  __ ldr(R6, FieldAddress(R1, TypedData::length_offset()));
+  __ cmp(R0, Operand(R6));
+  __ b(&fall_through, CS);
+
+  __ ldr(R1, FieldAddress(R1, ExternalTypedData::data_offset()));
+
+  // Untag R0;

[zra, 2014/05/30 18:11:00]

; -> .

[srdjan, 2014/05/30 19:23:12]

Done.

+  __ add(R1, R1, Operand(R0, LSR, 1));
+  __ ldr(R0, Address(R1, 0), kUnsignedByte);
+  __ SmiTag(R0);
+  __ ret();
+  __ Bind(&fall_through);
+}
+
+
 static int GetScaleFactor(intptr_t size) {
   switch (size) {
     case 1: return 0;