Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 308513004: Pass render frame ID to WebSocketBridge (Chromium side) (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
Reviewers:
Adam Rice, jam, yhirano
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Visibility:
Public.

Description

Pass render frame ID to WebSocketBridge (Chromium side) The browser side code of the new WebSocket stack needs to know the ID of the render frame where the corresponding WebSocketBridge is created in order to handle certificate errors. This CL just ports the code used by the old WebSocket implementation to new one. Blink side change: https://codereview.chromium.org/304113002/ BUG=364361 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274180

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M content/child/websocket_bridge.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/child/websocket_bridge.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-05-29 06:55:05 UTC) #1
yhirano
lgtm
6 years, 6 months ago (2014-05-29 07:10:23 UTC) #2
Adam Rice
lgtm
6 years, 6 months ago (2014-05-29 07:17:00 UTC) #3
tyoshino (SeeGerritForStatus)
jam@ for OWNER review
6 years, 6 months ago (2014-05-29 07:34:19 UTC) #4
jam
lgtm
6 years, 6 months ago (2014-05-29 17:32:04 UTC) #5
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-02 04:22:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/308513004/40001
6 years, 6 months ago (2014-06-02 04:22:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 06:01:19 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 07:35:15 UTC) #9
Message was sent while issue was closed.
Change committed as 274180

Powered by Google App Engine
This is Rietveld 408576698