Add start video marker into the trace

Add start video marker into the trace

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274072

[nduca, 2014-05-29 18:46:31]

lgtm with suggested bikeshed

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/tab.py (right):

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/tab.py:114:
console.time('__video_capture_start');
Thats fine, but the function issuign this is Highlight. So, you need to have the
name here be relative to this. __HighlightGone, for instance.

[nduca, 2014-05-29 18:47:04]

actually you should also land a unit test

[tonyg, 2014-05-29 19:18:47]

lg2m too with a comment and a unittest

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/tab.py (right):

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/tab.py:128: requestAnimationFrame(function() {
We should probably double-raf this one too. And maybe factor something out?

[nednguyen, 2014-05-29 20:33:38]

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/tab.py (right):

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/tab.py:110: document.body.appendChild(screen);
Can you add some comments while this needs 2 rAF?

[nednguyen, 2014-05-29 20:33:50]

lgtm

[Satyanarayana N H Manyam, 2014-05-30 00:20:09]

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/tab.py (right):

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/tab.py:110: document.body.appendChild(screen);
On 2014/05/29 20:33:38, nednguyen wrote:
> Can you add some comments while this needs 2 rAF

Nat can you send a one liner why this is needed, so that i can add a comment.

My understanding is bit vague here on the specifics.

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/tab.py:114:
console.time('__video_capture_start');
On 2014/05/29 18:46:31, nduca wrote:
> Thats fine, but the function issuign this is Highlight. So, you need to have
the
> name here be relative to this. __HighlightGone, for instance.

Done.

https://codereview.chromium.org/308513003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/tab.py:128: requestAnimationFrame(function() {
On 2014/05/29 19:18:47, tonyg wrote:
> We should probably double-raf this one too.
Done
maybe factor something out?
Skipping this for now.

[tonyg, 2014-05-30 01:42:17]

lgtm

[Satyanarayana N H Manyam, 2014-05-30 17:19:30]

The CQ bit was checked by satyanarayana@google.com

[Satyanarayana N H Manyam, 2014-05-30 17:19:35]

The CQ bit was unchecked by satyanarayana@google.com

[Satyanarayana N H Manyam, 2014-05-30 17:19:42]

The CQ bit was checked by satyanarayana@google.com

[commit-bot: I haz the power, 2014-05-30 17:23:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/satyanarayana@google.com/308513003/20001

[commit-bot: I haz the power, 2014-05-31 01:31:30]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-31 02:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-31 02:17:04]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[nednguyen, 2014-05-31 16:47:42]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-05-31 16:48:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/satyanarayana@google.com/308513003/20001

[commit-bot: I haz the power, 2014-05-31 22:27:21]

Change committed as 274072