Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 308513002: Fix fullscreen media control position issue when switching orientation (Closed)

Created:
6 years, 6 months ago by trchen
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Fix fullscreen media control position issue when switching orientation Currently we force page scale factor to 1.0 in fullscreen mode (whether it is a video or not). The assumption was broken when switching orientation. Adding extra check in screen resize code to make sure the constraint is enforced. R=aelias,qinmin BUG=376408 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175018

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove unnecessary scroll reset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/web/FullscreenController.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/FullscreenController.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
trchen
6 years, 6 months ago (2014-05-28 23:36:44 UTC) #1
aelias_OOO_until_Jul13
https://codereview.chromium.org/308513002/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/308513002/diff/1/Source/web/WebViewImpl.cpp#newcode1630 Source/web/WebViewImpl.cpp:1630: setPageScaleFactor(1.0f, IntPoint()); Why is this line needed?
6 years, 6 months ago (2014-05-28 23:45:54 UTC) #2
trchen
https://codereview.chromium.org/308513002/diff/1/Source/web/WebViewImpl.cpp File Source/web/WebViewImpl.cpp (right): https://codereview.chromium.org/308513002/diff/1/Source/web/WebViewImpl.cpp#newcode1630 Source/web/WebViewImpl.cpp:1630: setPageScaleFactor(1.0f, IntPoint()); On 2014/05/28 23:45:55, aelias wrote: > Why ...
6 years, 6 months ago (2014-05-29 00:02:12 UTC) #3
aelias_OOO_until_Jul13
lgtm
6 years, 6 months ago (2014-05-29 00:09:37 UTC) #4
trchen
The CQ bit was checked by trchen@chromium.org
6 years, 6 months ago (2014-05-29 00:10:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/308513002/20001
6 years, 6 months ago (2014-05-29 00:10:46 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 01:22:05 UTC) #7
Message was sent while issue was closed.
Change committed as 175018

Powered by Google App Engine
This is Rietveld 408576698