Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 308503002: [Password Generation] Start using pronouncable passwords (Closed)

Created:
6 years, 6 months ago by Garrett Casto
Modified:
6 years, 6 months ago
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, mkwst+watchlist_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[Password Generation] Start using pronouncable passwords BUG=165318 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276081

Patch Set 1 #

Total comments: 1

Patch Set 2 : Comments #

Total comments: 1

Patch Set 3 : Move DEPS #

Patch Set 4 : unnecessary includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -158 lines) Patch
M components/autofill.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/password_generator.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/password_generator.cc View 4 chunks +56 lines, -72 lines 0 comments Download
M components/autofill/core/browser/password_generator_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M third_party/fips181/convert.cc View 1 9 chunks +12 lines, -15 lines 0 comments Download
M third_party/fips181/fips181.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/fips181/fips181.cc View 1 7 chunks +14 lines, -36 lines 0 comments Download
M third_party/fips181/randpass.h View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/fips181/randpass.cc View 1 2 3 4 chunks +6 lines, -9 lines 0 comments Download
M third_party/fips181/smbl.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Garrett Casto
6 years, 6 months ago (2014-05-28 23:12:22 UTC) #1
Will Harris
On 2014/05/28 23:12:22, Garrett Casto wrote: I get compile errors on Win64 so I kicked ...
6 years, 6 months ago (2014-05-29 21:40:28 UTC) #2
Will Harris
one nit https://codereview.chromium.org/308503002/diff/1/third_party/fips181/fips181.h File third_party/fips181/fips181.h (right): https://codereview.chromium.org/308503002/diff/1/third_party/fips181/fips181.h#newcode69 third_party/fips181/fips181.h:69: #define S_SL 0x08 /* Small */ nit: ...
6 years, 6 months ago (2014-05-29 21:40:40 UTC) #3
Garrett Casto
+Ilya for autofill.gypi changes Will, is this going to need to go through security review ...
6 years, 6 months ago (2014-06-04 22:44:37 UTC) #4
Ilya Sherman
.gypi and deps fine LGTM % a nit https://codereview.chromium.org/308503002/diff/20001/components/autofill/DEPS File components/autofill/DEPS (right): https://codereview.chromium.org/308503002/diff/20001/components/autofill/DEPS#newcode6 components/autofill/DEPS:6: "+third_party/fips181", ...
6 years, 6 months ago (2014-06-04 22:48:50 UTC) #5
Garrett Casto
The CQ bit was checked by gcasto@chromium.org
6 years, 6 months ago (2014-06-09 19:49:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gcasto@chromium.org/308503002/60001
6 years, 6 months ago (2014-06-09 19:49:56 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 11:07:32 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 18:07:51 UTC) #9
Message was sent while issue was closed. 
Change committed as 276081

Powered by Google App Engine
This is Rietveld 408576698