Show window even if the parent window already contains the window

Show window even if the parent window already contains the window

The window may have changed visibility in the meantime. The web contents
controller may have navigated back, thus the window becomes visible. In this
case the window needs to be shown even if the parent contains it.

This aligns the shell_aura.cc implementation with shell_views.cc since in
the Views implementation the View::AddChildView() call would perform this
check and the widget would be shown by the next call to resize the widget
which happen regardless if View::AddChildView() was a no-op.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273692

[dnicoara, 2014-05-28 21:46:33]

jam@ for owners
skuhne@ FYI

jam@ let me know if there are side-effects that I haven't thought of.

This CL is required due to a recent change in how the web contents visibility is
processed (https://codereview.chromium.org/286943005/) while is causing the
Ozone builder to fail
RenderFrameHostManagerTest::SwappedOutViewHasCorrectVisibilityState

[jam, 2014-05-29 17:18:43]

lgtm

[dnicoara, 2014-05-29 17:20:13]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2014-05-29 17:25:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dnicoara@chromium.org/308463002/1

[commit-bot: I haz the power, 2014-05-29 23:11:04]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-30 01:38:36]

Change committed as 273692