chrome/browser/browser_process_impl.h - Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_impl.h

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to review Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_process_impl.h

diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h

index 5631a5ec3e927b006116a5e5967a52e15cdd81cd..932ca15dd90e00bce482304c091ca231e9d5e1a8 100644

--- a/chrome/browser/browser_process_impl.h

+++ b/chrome/browser/browser_process_impl.h

@@ -73,6 +73,7 @@ class BrowserProcessImpl : public BrowserProcess,

// BrowserProcess implementation.

virtual void ResourceDispatcherHostCreated() OVERRIDE;

virtual void EndSession() OVERRIDE;

+ virtual MetricsServicesManager* GetMetricsServicesManager() OVERRIDE;

virtual MetricsService* metrics_service() OVERRIDE;

virtual rappor::RapporService* rappor_service() OVERRIDE;

virtual IOThread* io_thread() OVERRIDE;

@@ -152,8 +153,6 @@ class BrowserProcessImpl : public BrowserProcess,

void CreateStatusTray();

void CreateBackgroundModeManager();

- MetricsServicesManager* GetMetricsServicesManager();

void ApplyAllowCrossOriginAuthPromptPolicy();

void ApplyDefaultBrowserPolicy();

void ApplyMetricsReportingPolicy();

« no previous file with comments | « chrome/browser/browser_process.h ('k') | chrome/browser/browser_process_impl.cc » ('j') | chrome/browser/metrics/metrics_services_manager.h » ('J')