chrome/browser/metrics/plugin_metrics_provider.h - Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/plugin_metrics_provider.h

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/metrics_service.cc ('K') | « chrome/browser/metrics/metrics_services_manager.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/plugin_metrics_provider.h

diff --git a/chrome/browser/metrics/plugin_metrics_provider.h b/chrome/browser/metrics/plugin_metrics_provider.h

index 14ba2222da6d121859ec0871c6d9c39e68c72d06..baabcf746df0bc5a1f499815ca0898d56e7078d0 100644

--- a/chrome/browser/metrics/plugin_metrics_provider.h

+++ b/chrome/browser/metrics/plugin_metrics_provider.h

@@ -42,10 +42,7 @@ class PluginMetricsProvider : public metrics::MetricsProvider,

metrics::SystemProfileProto* system_profile_proto) OVERRIDE;

virtual void ProvideStabilityMetrics(

metrics::SystemProfileProto* system_profile_proto) OVERRIDE;

- // Saves plugin-related updates from the in-object buffer to Local State

- // for retrieval next time we send a Profile log (generally next launch).

- void RecordPluginChanges();

+ virtual void RecordCurrentState() OVERRIDE;

// Notifies the provider about an error loading the plugin at |plugin_path|.

void LogPluginLoadingError(const base::FilePath& plugin_path);