Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/browser_process_impl.cc

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Response to review Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/browser_process_impl.h" 5 #include "chrome/browser/browser_process_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 // so that there's no race to reference it in Signal(). 418 // so that there's no race to reference it in Signal().
419 if (!done_writing->TimedWait( 419 if (!done_writing->TimedWait(
420 base::TimeDelta::FromSeconds(kEndSessionTimeoutSeconds))) { 420 base::TimeDelta::FromSeconds(kEndSessionTimeoutSeconds))) {
421 ignore_result(done_writing.release()); 421 ignore_result(done_writing.release());
422 } 422 }
423 #else 423 #else
424 NOTIMPLEMENTED(); 424 NOTIMPLEMENTED();
425 #endif 425 #endif
426 } 426 }
427 427
428 MetricsServicesManager* BrowserProcessImpl::GetMetricsServicesManager() {
429 DCHECK(CalledOnValidThread());
430 if (!metrics_services_manager_)
431 metrics_services_manager_.reset(new MetricsServicesManager(local_state()));
432 return metrics_services_manager_.get();
433 }
434
428 MetricsService* BrowserProcessImpl::metrics_service() { 435 MetricsService* BrowserProcessImpl::metrics_service() {
429 DCHECK(CalledOnValidThread()); 436 DCHECK(CalledOnValidThread());
430 return GetMetricsServicesManager()->GetMetricsService(); 437 return GetMetricsServicesManager()->GetMetricsService();
431 } 438 }
432 439
433 rappor::RapporService* BrowserProcessImpl::rappor_service() { 440 rappor::RapporService* BrowserProcessImpl::rappor_service() {
434 DCHECK(CalledOnValidThread()); 441 DCHECK(CalledOnValidThread());
435 return GetMetricsServicesManager()->GetRapporService(); 442 return GetMetricsServicesManager()->GetRapporService();
436 } 443 }
437 444
(...skipping 538 matching lines...) Expand 10 before | Expand all | Expand 10 after
976 DCHECK(safe_browsing_service_.get() == NULL); 983 DCHECK(safe_browsing_service_.get() == NULL);
977 // Set this flag to true so that we don't retry indefinitely to 984 // Set this flag to true so that we don't retry indefinitely to
978 // create the service class if there was an error. 985 // create the service class if there was an error.
979 created_safe_browsing_service_ = true; 986 created_safe_browsing_service_ = true;
980 #if defined(FULL_SAFE_BROWSING) || defined(MOBILE_SAFE_BROWSING) 987 #if defined(FULL_SAFE_BROWSING) || defined(MOBILE_SAFE_BROWSING)
981 safe_browsing_service_ = SafeBrowsingService::CreateSafeBrowsingService(); 988 safe_browsing_service_ = SafeBrowsingService::CreateSafeBrowsingService();
982 safe_browsing_service_->Initialize(); 989 safe_browsing_service_->Initialize();
983 #endif 990 #endif
984 } 991 }
985 992
986 MetricsServicesManager* BrowserProcessImpl::GetMetricsServicesManager() {
987 DCHECK(CalledOnValidThread());
988 if (!metrics_services_manager_)
989 metrics_services_manager_.reset(new MetricsServicesManager(local_state()));
990 return metrics_services_manager_.get();
991 }
992
993 void BrowserProcessImpl::ApplyDefaultBrowserPolicy() { 993 void BrowserProcessImpl::ApplyDefaultBrowserPolicy() {
994 if (local_state()->GetBoolean(prefs::kDefaultBrowserSettingEnabled)) { 994 if (local_state()->GetBoolean(prefs::kDefaultBrowserSettingEnabled)) {
995 scoped_refptr<ShellIntegration::DefaultWebClientWorker> 995 scoped_refptr<ShellIntegration::DefaultWebClientWorker>
996 set_browser_worker = new ShellIntegration::DefaultBrowserWorker(NULL); 996 set_browser_worker = new ShellIntegration::DefaultBrowserWorker(NULL);
997 set_browser_worker->StartSetAsDefault(); 997 set_browser_worker->StartSetAsDefault();
998 } 998 }
999 } 999 }
1000 1000
1001 void BrowserProcessImpl::ApplyAllowCrossOriginAuthPromptPolicy() { 1001 void BrowserProcessImpl::ApplyAllowCrossOriginAuthPromptPolicy() {
1002 bool value = local_state()->GetBoolean(prefs::kAllowCrossOriginAuthPrompt); 1002 bool value = local_state()->GetBoolean(prefs::kAllowCrossOriginAuthPrompt);
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 } 1063 }
1064 1064
1065 void BrowserProcessImpl::OnAutoupdateTimer() { 1065 void BrowserProcessImpl::OnAutoupdateTimer() {
1066 if (CanAutorestartForUpdate()) { 1066 if (CanAutorestartForUpdate()) {
1067 DLOG(WARNING) << "Detected update. Restarting browser."; 1067 DLOG(WARNING) << "Detected update. Restarting browser.";
1068 RestartBackgroundInstance(); 1068 RestartBackgroundInstance();
1069 } 1069 }
1070 } 1070 }
1071 1071
1072 #endif // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS) 1072 #endif // (defined(OS_WIN) || defined(OS_LINUX)) && !defined(OS_CHROMEOS)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698