Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chrome/browser/metrics/metrics_service.h

Issue 308433004: Reduce plugin_metrics_provider_ usage in MetricsService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file defines a service that collects information about the user 5 // This file defines a service that collects information about the user
6 // experience in order to help improve future versions of the app. 6 // experience in order to help improve future versions of the app.
7 7
8 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_H_ 8 #ifndef CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
9 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_H_ 9 #define CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
10 10
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 // This count is eventually send via UMA logs. 200 // This count is eventually send via UMA logs.
201 void RecordBreakpadRegistration(bool success); 201 void RecordBreakpadRegistration(bool success);
202 202
203 // Saves in the preferences if the browser is running under a debugger. 203 // Saves in the preferences if the browser is running under a debugger.
204 // This count is eventually send via UMA logs. 204 // This count is eventually send via UMA logs.
205 void RecordBreakpadHasDebugger(bool has_debugger); 205 void RecordBreakpadHasDebugger(bool has_debugger);
206 206
207 bool recording_active() const; 207 bool recording_active() const;
208 bool reporting_active() const; 208 bool reporting_active() const;
209 209
210 void LogPluginLoadingError(const base::FilePath& plugin_path); 210 // TODO(blundell): Move this into ChromeMetricsServiceClient.
211 PluginMetricsProvider* plugin_metrics_provider() {
212 return plugin_metrics_provider_;
213 }
211 214
212 // Redundant test to ensure that we are notified of a clean exit. 215 // Redundant test to ensure that we are notified of a clean exit.
213 // This value should be true when process has completed shutdown. 216 // This value should be true when process has completed shutdown.
214 static bool UmaMetricsProperlyShutdown(); 217 static bool UmaMetricsProperlyShutdown();
215 218
216 // Registers a field trial name and group to be used to annotate a UMA report 219 // Registers a field trial name and group to be used to annotate a UMA report
217 // with a particular Chrome configuration state. A UMA report will be 220 // with a particular Chrome configuration state. A UMA report will be
218 // annotated with this trial group if and only if all events in the report 221 // annotated with this trial group if and only if all events in the report
219 // were created after the trial is registered. Only one group name may be 222 // were created after the trial is registered. Only one group name may be
220 // registered at a time for a given trial_name. Only the last group name that 223 // registered at a time for a given trial_name. Only the last group name that
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, IsPluginProcess); 523 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, IsPluginProcess);
521 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, MetricsServiceObserver); 524 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, MetricsServiceObserver);
522 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, 525 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest,
523 PermutedEntropyCacheClearedWhenLowEntropyReset); 526 PermutedEntropyCacheClearedWhenLowEntropyReset);
524 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, RegisterSyntheticTrial); 527 FRIEND_TEST_ALL_PREFIXES(MetricsServiceTest, RegisterSyntheticTrial);
525 528
526 DISALLOW_COPY_AND_ASSIGN(MetricsService); 529 DISALLOW_COPY_AND_ASSIGN(MetricsService);
527 }; 530 };
528 531
529 #endif // CHROME_BROWSER_METRICS_METRICS_SERVICE_H_ 532 #endif // CHROME_BROWSER_METRICS_METRICS_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698