chrome/browser/ui/cocoa/browser_window_cocoa.mm - Issue 308433002: Desktop Menu UMA for Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 308433002: Desktop Menu UMA for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename variables; subViews to access profileChooserController for UMA Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

index 407d651b43890010f91505c036c7609cfaed4641..3213b7d89118b265f93bb57afa0c3552a57c6a8c 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm

@@ -710,9 +710,9 @@ void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(

NSView* anchor = [controller buttonView];

if ([anchor isHiddenOrHasHiddenAncestor])

anchor = [[controller_ toolbarController] wrenchButton];

- // TODO(mlerman): pass |service_type| to profile_chooser_controller to

- // implement UMA instrumentation of the menu.

- [controller showAvatarBubble:anchor withMode:mode];

+ [controller showAvatarBubble:anchor

+ withMode:mode

+ withServiceType:service_type];

}

void BrowserWindowCocoa::ShowPasswordGenerationBubble(

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('j') | no next file with comments »