Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm

Issue 308433002: Desktop Menu UMA for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
diff --git a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
index 88b8f00def2ce9589f6e84011039e21fccc5f9cb..3a4dfde3129241af2540abc92ff5f21af86490f5 100644
--- a/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
+++ b/chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm
@@ -10,6 +10,7 @@
#include "chrome/browser/profiles/profile_avatar_icon_util.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "chrome/browser/profiles/profile_metrics.h"
+#include "chrome/browser/signin/signin_header_helper.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
#include "chrome/browser/ui/browser_window.h"
@@ -98,7 +99,8 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver {
}
- (void)showAvatarBubble:(NSView*)anchor
- withMode:(BrowserWindow::AvatarBubbleMode)mode {
+ withMode:(BrowserWindow::AvatarBubbleMode)mode
+ withServiceType:(signin::GAIAServiceType)GAIAServiceType {
if (menuController_)
return;
@@ -129,7 +131,8 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver {
menuController_ =
[[ProfileChooserController alloc] initWithBrowser:browser_
anchoredAt:point
- withMode:viewMode];
+ withMode:viewMode
+ withServiceType:GAIAServiceType];
} else {
menuController_ =
[[AvatarMenuBubbleController alloc] initWithBrowser:browser_
@@ -149,7 +152,8 @@ class ProfileInfoUpdateObserver : public ProfileInfoCacheObserver {
- (IBAction)buttonClicked:(id)sender {
DCHECK_EQ(sender, button_.get());
[self showAvatarBubble:button_
- withMode:BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT];
+ withMode:BrowserWindow::AVATAR_BUBBLE_MODE_DEFAULT
+ withServiceType:signin::GAIA_SERVICE_TYPE_NONE];
}
- (void)bubbleWillClose:(NSNotification*)notif {

Powered by Google App Engine
This is Rietveld 408576698