Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 308433002: Desktop Menu UMA for Mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('j') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index 407d651b43890010f91505c036c7609cfaed4641..3213b7d89118b265f93bb57afa0c3552a57c6a8c 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -710,9 +710,9 @@ void BrowserWindowCocoa::ShowAvatarBubbleFromAvatarButton(
NSView* anchor = [controller buttonView];
if ([anchor isHiddenOrHasHiddenAncestor])
anchor = [[controller_ toolbarController] wrenchButton];
- // TODO(mlerman): pass |service_type| to profile_chooser_controller to
- // implement UMA instrumentation of the menu.
- [controller showAvatarBubble:anchor withMode:mode];
+ [controller showAvatarBubble:anchor
+ withMode:mode
+ withServiceType:service_type];
}
void BrowserWindowCocoa::ShowPasswordGenerationBubble(
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('j') | chrome/browser/ui/cocoa/profiles/avatar_base_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698