Desktop Menu UMA for Mac

chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #import "chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h"
 
 #include "base/mac/bundle_locations.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/profiles/avatar_menu.h"
 #include "chrome/browser/profiles/avatar_menu_observer.h"
 #include "chrome/browser/profiles/profile_avatar_icon_util.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/profiles/profile_metrics.h"
 #include "chrome/browser/profiles/profile_window.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
+#include "chrome/browser/signin/signin_header_helper.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/signin/signin_promo.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/chrome_style.h"
 #import "chrome/browser/ui/cocoa/hyperlink_text_view.h"
 #import "chrome/browser/ui/cocoa/info_bubble_view.h"
@@ skipping 388 matching lines @@
   [path addClip];
   [self.image drawAtPoint:bounds.origin
                  fromRect:bounds
                 operation:NSCompositeSourceOver
                  fraction:1.0];
 
 }
 
 - (void)editPhoto:(id)sender {
   avatarMenu_->EditProfile(avatarMenu_->GetActiveProfileIndex());
+  [self postActionPerformed:ProfileMetrics::PROFILE_DESKTOP_MENU_EDIT_IMAGE];
 }
 
 - (void)mouseEntered:(NSEvent*)event {
   [changePhotoButton_ setHidden:NO];
 }
 
 - (void)mouseExited:(NSEvent*)event {
   [changePhotoButton_ setHidden:YES];
 }
 
@@ skipping 83 matching lines @@
   return self;
 }
 
 // NSTextField objects send an NSNotification to a delegate if
 // it implements this method:
 - (void)controlTextDidEndEditing:(NSNotification *)obj {
   NSString* text = [profileNameTextField_ stringValue];
   // Empty profile names are not allowed, and are treated as a cancel.
   if ([text length] > 0) {
     profiles::UpdateProfileName(profile_, base::SysNSStringToUTF16(text));
+    [self postActionPerformed:ProfileMetrics::PROFILE_DESKTOP_MENU_EDIT_NAME];
     [self setTitle:text];
   }
   [profileNameTextField_ setHidden:YES];
   [profileNameTextField_ resignFirstResponder];
 }
 
 - (void)showEditableView:(id)sender {
   [profileNameTextField_ setHidden:NO];
   [profileNameTextField_ becomeFirstResponder];
 }
@@ skipping 185 matching lines @@
 - (NSButton*)linkButtonWithTitle:(NSString*)title
                      frameOrigin:(NSPoint)frameOrigin
                           action:(SEL)action;
 
 // Creates an email account button with |title| and a remove icon. |tag|
 // indicates which account the button refers to.
 - (NSButton*)accountButtonWithRect:(NSRect)rect
                              title:(const std::string&)title
                                tag:(int)tag;
 
+// Clean-up done after an action was performed in the ProfileChooser.
+- (void)postActionPerformed:(ProfileMetrics::ProfileDesktopMenu)action;

[Scott Hess - ex-Googler, 2014/05/30 04:09:27]

I think it's weird to have this down here though it's already been used
elsewhere in the file.  You should arrange to have it higher up somewhere in a
private interface or something.  I see lots of inline interfaces and
implementations, so I'm not going to decode what all is going on in here, but
I'm sure there is something earlier which makes sense.

That said, I'm not 100% certain about having it be a helper method versus some
sort of anonymous-namespace helper.  I guess resetting the instance variable is
valuable, and a c++-level helper wouldn't have access to that without
contortions.  So I'm talking myself right out of that.

[Mike Lerman, 2014/05/30 17:46:25]

Done... I guess... since there's nothing for me to do?

I passed the ProfileChooserController to the subViews so I can call
postActionPerformed. Can you review that part?

+
 @end
 
 @implementation ProfileChooserController
 - (profiles::BubbleViewMode) viewMode {
   return viewMode_;
 }
 
 - (IBAction)switchToProfile:(id)sender {
   // Check the event flags to see if a new window should be created.
   bool alwaysCreate = ui::WindowOpenDispositionFromNSEvent(
@@ skipping 15 matching lines @@
 - (IBAction)showAccountManagement:(id)sender {
   [self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT];
 }
 
 - (IBAction)hideAccountManagement:(id)sender {
   [self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER];
 }
 
 - (IBAction)lockProfile:(id)sender {
   profiles::LockProfile(browser_->profile());
+  [self postActionPerformed:ProfileMetrics::PROFILE_DESKTOP_MENU_LOCK];
 }
 
 - (IBAction)showInlineSigninPage:(id)sender {
   [self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_GAIA_SIGNIN];
 }
 
 - (IBAction)showTabbedSigninPage:(id)sender {
   chrome::ShowBrowserSignin(browser_, signin::SOURCE_MENU);
 }
 
 - (IBAction)addAccount:(id)sender {
   [self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_GAIA_ADD_ACCOUNT];
+  [self postActionPerformed:ProfileMetrics::PROFILE_DESKTOP_MENU_ADD_ACCT];
 }
 
 - (IBAction)navigateBackFromSigninPage:(id)sender {
   std::string primaryAccount = SigninManagerFactory::GetForProfile(
       browser_->profile())->GetAuthenticatedUsername();
   [self initMenuContentsWithView:primaryAccount.empty() ?
       profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER :
       profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT];
 }
 
@@ skipping 11 matching lines @@
     accountIdToRemove_ = currentProfileAccounts_[tag];
   }
 
   [self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_ACCOUNT_REMOVAL];
 }
 
 - (IBAction)removeAccount:(id)sender {
   DCHECK(!accountIdToRemove_.empty());
   ProfileOAuth2TokenServiceFactory::GetPlatformSpecificForProfile(
       browser_->profile())->RevokeCredentials(accountIdToRemove_);
+  [self postActionPerformed:ProfileMetrics::PROFILE_DESKTOP_MENU_REMOVE_ACCT];
   accountIdToRemove_.clear();
 
   [self initMenuContentsWithView:profiles::BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT];
 }
 
 - (IBAction)openTutorialLearnMoreURL:(id)sender {
   ProfileMetrics::LogProfileUpgradeEnrollment(
       ProfileMetrics::PROFILE_ENROLLMENT_LAUNCH_LEARN_MORE);
   // TODO(guohui): update |learnMoreUrl| once it is decided.
   const GURL learnMoreUrl("https://support.google.com/chrome/?hl=en#to");
@@ skipping 39 matching lines @@
 - (IBAction)endPreviewAndRelaunch:(id)sender {
   profiles::DisableNewProfileManagementPreview();
 }
 
 - (void)cleanUpEmbeddedViewContents {
   webContents_.reset();
 }
 
 - (id)initWithBrowser:(Browser*)browser
            anchoredAt:(NSPoint)point
-             withMode:(profiles::BubbleViewMode)mode {
+             withMode:(profiles::BubbleViewMode)mode
+      withServiceType:(signin::GAIAServiceType)GAIAServiceType {
   base::scoped_nsobject<InfoBubbleWindow> window([[InfoBubbleWindow alloc]
       initWithContentRect:ui::kWindowSizeDeterminedLater
                 styleMask:NSBorderlessWindowMask
                   backing:NSBackingStoreBuffered
                     defer:NO]);
 
   if ((self = [super initWithWindow:window
                        parentWindow:browser->window()->GetNativeWindow()
                          anchoredAt:point])) {
     browser_ = browser;
     viewMode_ = mode;
     tutorialMode_ = profiles::TUTORIAL_MODE_NONE;
     observer_.reset(new ActiveProfileObserverBridge(self, browser_));
+    GAIAServiceType_ = GAIAServiceType;
 
     avatarMenu_.reset(new AvatarMenu(
         &g_browser_process->profile_manager()->GetProfileInfoCache(),
         observer_.get(),
         browser_));
     avatarMenu_->RebuildMenu();
 
     // Guest profiles do not have a token service.
     isGuestSession_ = browser_->profile()->IsGuestSession();
 
@@ skipping 810 matching lines @@
   [deleteButton setPressedImage:rb->GetNativeImageNamed(
       IDR_CLOSE_1_P).ToNSImage()];
   [deleteButton setTarget:self];
   [deleteButton setAction:@selector(showAccountRemovalView:)];
   [deleteButton setTag:tag];
 
   [button addSubview:deleteButton];
   return button.autorelease();
 }
 
+- (void)postActionPerformed:(ProfileMetrics::ProfileDesktopMenu)action {
+  ProfileMetrics::LogProfileDesktopMenu(action, GAIAServiceType_);
+  GAIAServiceType_ = signin::GAIA_SERVICE_TYPE_NONE;
+}
+
 @end