|
Revert of Move some sync/notifier to components/invalidation ( https://codereview.chromium.org/294123004/)
Reason for revert:
Passed the CQ but broke the buildbot.
Original issue's description:
> Move some sync/notifier to components/invalidation
>
> Moves many of the files in sync/notifier to components/invalidation.
>
> This change does not introduce any new dependencies. The relevant
> dependency rules both before and after this change should be:
> - chrome/browser/invalidation and chrome in general depend on
> components/invalidation.
> - components/invalidation depends on sync/notifier and sync in
> general.
> - sync/notifier, components/invalidation, and various parts of
> chrome all depend on sync/internal_api/public.
>
> The eventual goal is to move all of sync/notifier into
> components/invalidation. The invalidation-related parts of
> sync/internal_api/public should be moved to components/invalidation,
> too. This will allow us to remove the deopendencies from
> components/invalidation to sync, and remove sync's dependencies on
> cacheinvalidation and libjingle.
>
> This change is a regression in terms of shared library componentization.
> the files in the sync/notifier folder could be built as a shared
> library. The files in compononents/invalidation do not support this
> yet. The SYNC_EXPORT declarations in the moved files have been changed
> to INVALIDATION_EXPORT so as to not lose this information, but the
> macros are currently #defined to no-ops.
>
> This change does not attempt to rename any classes or namespaces.
> Many of the files ported from sync/notifier still use the syncer
> namespace. Some, like SyncSystemResources, still have names tied
> to their sync heritage. This will be addressed in future CLs.
>
> Some non-trivial or non-obvious changes include:
> - invalidator_state.h was moved to sync/internal_api/public/base so it
> could be shared by both sync/ and components/invalidation. This should
> be fixed in a future CL.
> - FromNotifierReason was split out of invalidator_state.h and moved to
> the newly-created components/invalidator_reason_util.h
>
> TBR=zea,rtenneti,mallinath,dcheng
> BUG= 259559
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274350
TBR=pavely@chromium.org,dcheng@chromium.org,zea@chromium.org,rtenneti@chromium.org,mallinath@chromium.org,maniscalco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 259559
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274364
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+7265 lines, -7347 lines) |
Patch |
 |
M |
chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/fake_invalidation_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/gcm_invalidation_bridge.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/invalidation_service_android.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/invalidation_service_android_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/invalidation_service_test_template.h
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_invalidation_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_invalidation_service.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_invalidation_service_unittest.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/integration/fake_server_invalidation_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/test/integration/sync_test.cc
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests_unit.gypi
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
components/components_tests.gyp
|
View
|
|
2 chunks |
+0 lines, -14 lines |
0 comments
|
Download
|
 |
M |
components/invalidation.gypi
|
View
|
|
4 chunks |
+3 lines, -47 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/DEPS
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/fake_invalidation_handler.h
|
View
|
|
1 chunk |
+0 lines, -42 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/fake_invalidation_handler.cc
|
View
|
|
1 chunk |
+0 lines, -40 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/fake_invalidation_state_tracker.h
|
View
|
|
1 chunk |
+0 lines, -42 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/fake_invalidation_state_tracker.cc
|
View
|
|
1 chunk |
+0 lines, -55 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/fake_invalidator.h
|
View
|
|
1 chunk |
+0 lines, -53 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/fake_invalidator.cc
|
View
|
|
1 chunk |
+0 lines, -69 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/fake_invalidator_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -63 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/gcm_network_channel.h
|
View
|
|
1 chunk |
+0 lines, -135 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/gcm_network_channel.cc
|
View
|
|
1 chunk |
+0 lines, -430 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/gcm_network_channel_delegate.h
|
View
|
|
1 chunk |
+0 lines, -51 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/gcm_network_channel_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -494 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidation_export.h
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/invalidation_logger.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/invalidation/invalidation_logger_observer.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidation_notifier.h
|
View
|
|
1 chunk |
+0 lines, -108 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidation_notifier.cc
|
View
|
|
1 chunk |
+0 lines, -93 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidation_notifier_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -92 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/invalidation_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidator_registrar.h
|
View
|
|
1 chunk |
+0 lines, -97 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidator_registrar.cc
|
View
|
|
1 chunk |
+0 lines, -149 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidator_registrar_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -163 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidator_test_template.h
|
View
|
|
1 chunk |
+0 lines, -377 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/invalidator_test_template.cc
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/non_blocking_invalidator.h
|
View
|
|
1 chunk |
+0 lines, -114 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/non_blocking_invalidator.cc
|
View
|
|
1 chunk |
+0 lines, -367 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/non_blocking_invalidator_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -98 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/notifier_reason_util.h
|
View
|
|
1 chunk |
+0 lines, -22 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/notifier_reason_util.cc
|
View
|
|
1 chunk |
+0 lines, -41 lines |
0 comments
|
Download
|
 |
M |
components/invalidation/p2p_invalidation_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/invalidation/p2p_invalidation_service.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
D |
components/invalidation/p2p_invalidator.h
|
View
|
|
1 chunk |
+0 lines, -150 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/p2p_invalidator.cc
|
View
|
|
1 chunk |
+0 lines, -300 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/p2p_invalidator_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -357 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/push_client_channel.h
|
View
|
|
1 chunk |
+0 lines, -91 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/push_client_channel.cc
|
View
|
|
1 chunk |
+0 lines, -162 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/push_client_channel_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -252 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/state_writer.h
|
View
|
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/sync_invalidation_listener.h
|
View
|
|
1 chunk |
+0 lines, -196 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/sync_invalidation_listener.cc
|
View
|
|
1 chunk |
+0 lines, -443 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/sync_invalidation_listener_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1129 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/sync_system_resources.h
|
View
|
|
1 chunk |
+0 lines, -241 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/sync_system_resources.cc
|
View
|
|
1 chunk |
+0 lines, -333 lines |
0 comments
|
Download
|
 |
D |
components/invalidation/sync_system_resources_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -249 lines |
0 comments
|
Download
|
 |
D |
sync/internal_api/public/base/invalidator_state.h
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
 |
D |
sync/internal_api/public/base/invalidator_state.cc
|
View
|
|
1 chunk |
+0 lines, -25 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/test/fake_sync_manager.h
|
View
|
|
2 chunks |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/internal_api/sync_manager_impl_unittest.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/test/fake_sync_manager.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/notifier/DEPS
|
View
|
|
1 chunk |
+13 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/fake_invalidation_handler.h
|
View
|
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/fake_invalidation_handler.cc
|
View
|
|
1 chunk |
+40 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/fake_invalidation_state_tracker.h
|
View
|
|
1 chunk |
+42 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/fake_invalidation_state_tracker.cc
|
View
|
|
1 chunk |
+55 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/fake_invalidator.h
|
View
|
|
1 chunk |
+53 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/fake_invalidator.cc
|
View
|
|
1 chunk |
+69 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/fake_invalidator_unittest.cc
|
View
|
|
1 chunk |
+63 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/gcm_network_channel.h
|
View
|
|
1 chunk |
+135 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/gcm_network_channel.cc
|
View
|
|
1 chunk |
+430 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/gcm_network_channel_delegate.h
|
View
|
|
1 chunk |
+51 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/gcm_network_channel_unittest.cc
|
View
|
|
1 chunk |
+494 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/notifier/invalidation_handler.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidation_notifier.h
|
View
|
|
1 chunk |
+108 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidation_notifier.cc
|
View
|
|
1 chunk |
+93 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidation_notifier_unittest.cc
|
View
|
|
1 chunk |
+92 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/notifier/invalidation_state_tracker.h
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
sync/notifier/invalidation_state_tracker.cc
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
 |
M |
sync/notifier/invalidator.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidator_registrar.h
|
View
|
|
1 chunk |
+97 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidator_registrar.cc
|
View
|
|
1 chunk |
+149 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidator_registrar_unittest.cc
|
View
|
|
1 chunk |
+163 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidator_state.h
|
View
|
|
1 chunk |
+38 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidator_state.cc
|
View
|
|
1 chunk |
+55 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidator_test_template.h
|
View
|
|
1 chunk |
+377 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/invalidator_test_template.cc
|
View
|
|
1 chunk |
+28 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/non_blocking_invalidator.h
|
View
|
|
1 chunk |
+114 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/non_blocking_invalidator.cc
|
View
|
|
1 chunk |
+367 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/non_blocking_invalidator_unittest.cc
|
View
|
|
1 chunk |
+98 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/p2p_invalidator.h
|
View
|
|
1 chunk |
+150 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/p2p_invalidator.cc
|
View
|
|
1 chunk |
+299 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/p2p_invalidator_unittest.cc
|
View
|
|
1 chunk |
+355 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/push_client_channel.h
|
View
|
|
1 chunk |
+91 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/push_client_channel.cc
|
View
|
|
1 chunk |
+161 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/push_client_channel_unittest.cc
|
View
|
|
1 chunk |
+252 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/state_writer.h
|
View
|
|
1 chunk |
+25 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/sync_invalidation_listener.h
|
View
|
|
1 chunk |
+196 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/sync_invalidation_listener.cc
|
View
|
|
1 chunk |
+443 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/sync_invalidation_listener_unittest.cc
|
View
|
|
1 chunk |
+1129 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/sync_system_resources.h
|
View
|
|
1 chunk |
+241 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/sync_system_resources.cc
|
View
|
|
1 chunk |
+333 lines, -0 lines |
0 comments
|
Download
|
 |
A |
sync/notifier/sync_system_resources_unittest.cc
|
View
|
|
1 chunk |
+249 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/notifier/unacked_invalidation_set.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
sync/sync_internal_api.gypi
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/sync_notifier.gypi
|
View
|
|
2 chunks |
+20 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/sync_tests.gypi
|
View
|
|
2 chunks |
+17 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/tools/DEPS
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
sync/tools/sync_client.cc
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/tools/sync_listen_notifications.cc
|
View
|
|
2 chunks |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/tools/sync_tools.gyp
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|