Issue 3084006: Fix CrOS build.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3084006: Fix CrOS build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Lei Zhang

Modified:
4 years ago

Reviewers:
viettrungluu

CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix CrOS build. BUG=none TEST=CrOS bot goes green? TBR=vtl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54438

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -0 lines)			Patch
M	chrome/browser/chromeos/options/internet_page_view.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/language_config_util.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/options/settings_page_view.cc	View	1 chunk	+3 lines, -0 lines	1 comment	Download
M	chrome/browser/chromeos/options/system_page_view.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/volume_bubble_view.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

4 years, 10 months ago (2010-07-31 07:37:28 UTC) #2

LGTM, if it fixes the build, that is. (But go for it.)

There were some other files with failures, but maybe they're covered by the
header file change.

http://codereview.chromium.org/3084006/diff/1/4
File chrome/browser/chromeos/options/settings_page_view.cc (right):

http://codereview.chromium.org/3084006/diff/1/4#newcode9
chrome/browser/chromeos/options/settings_page_view.cc:9: #include
"base/string_util.h"
Is string_util.h really needed?

Expand Messages | Collapse Messages