Chromium Code Reviews
Help | Chromium Project | Sign in
(210)

Issue 3084006: Fix CrOS build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 10 months ago by Lei Zhang
Modified:
4 years ago
Reviewers:
viettrungluu
CC:
chromium-reviews, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Fix CrOS build. BUG=none TEST=CrOS bot goes green? TBR=vtl Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54438

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/chromeos/options/internet_page_view.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/options/settings_page_view.cc View 1 chunk +3 lines, -0 lines 1 comment Download
M chrome/browser/chromeos/options/system_page_view.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/volume_bubble_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
Lei Zhang
4 years, 10 months ago (2010-07-31 07:34:51 UTC) #1
viettrungluu
4 years, 10 months ago (2010-07-31 07:37:28 UTC) #2
LGTM, if it fixes the build, that is. (But go for it.)

There were some other files with failures, but maybe they're covered by the
header file change.

http://codereview.chromium.org/3084006/diff/1/4
File chrome/browser/chromeos/options/settings_page_view.cc (right):

http://codereview.chromium.org/3084006/diff/1/4#newcode9
chrome/browser/chromeos/options/settings_page_view.cc:9: #include
"base/string_util.h"
Is string_util.h really needed?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be