Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 308353002: Add dependency on buildtools repo (Closed)

Created:
6 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Add dependency on buildtools repo Currently, this adds checkdeps, in the future, this will be the place where clang-format and gn lives. BUG=none R=machenbach@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M .DEPS.git View 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 2 chunks +6 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-02 14:21:09 UTC) #1
Michael Achenbach
LGTM
6 years, 6 months ago (2014-06-03 09:09:26 UTC) #2
jochen (gone - plz use gerrit)
6 years, 6 months ago (2014-06-03 12:01:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698