Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 30833003: Add code to load Hangout Services as a component extension. (Closed)

Created:
7 years, 2 months ago by Jói
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Add code to load Hangout Services as a component extension. Rename the extension from "Hangouts Services" to "Hangout Services". Add public key and add ID to appropriate whitelists. TBR=jochen@chromium.org BUG=291271 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230693

Patch Set 1 #

Patch Set 2 : Merge LKGR. #

Patch Set 3 : Merge to head for tryjobs. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -89 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +7 lines, -0 lines 2 comments Download
A + chrome/browser/resources/hangout_services/icon_128.png View Binary file 0 comments Download
A + chrome/browser/resources/hangout_services/manifest.json View 1 chunk +4 lines, -1 line 0 comments Download
A + chrome/browser/resources/hangout_services/thunk.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/browser/resources/hangouts_services/icon_128.png View Binary file 0 comments Download
D chrome/browser/resources/hangouts_services/manifest.json View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/resources/hangouts_services/thunk.js View 1 chunk +0 lines, -65 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 2 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jói
Victoria, this makes the extension load as a component extension. Will find appropriate owners after ...
7 years, 2 months ago (2013-10-23 17:45:02 UTC) #1
Jói
nkostylev: Could you review the changes to chrome/browser/resources? This is just a rename plus adding ...
7 years, 2 months ago (2013-10-23 18:32:10 UTC) #2
Nikita (slow)
lgtm
7 years, 2 months ago (2013-10-23 21:07:40 UTC) #3
Jói
+yoz@ instead of finnur@ to optimize for time zone :) Yoyo, if you have time ...
7 years, 2 months ago (2013-10-23 22:00:04 UTC) #4
Yoyo Zhou
LGTM https://codereview.chromium.org/30833003/diff/210001/chrome/browser/extensions/component_loader.cc File chrome/browser/extensions/component_loader.cc (right): https://codereview.chromium.org/30833003/diff/210001/chrome/browser/extensions/component_loader.cc#newcode436 chrome/browser/extensions/component_loader.cc:436: AddHangoutServicesExtension(); Can this (and other such functions) be ...
7 years, 2 months ago (2013-10-23 23:24:27 UTC) #5
Jói
TBR=jochen@chromium.org for browser_resources.grd change. Yoyo, see below. If I misunderstood your suggestion and you had ...
7 years, 2 months ago (2013-10-24 08:23:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/30833003/210001
7 years, 2 months ago (2013-10-24 09:16:49 UTC) #7
commit-bot: I haz the power
Change committed as 230693
7 years, 2 months ago (2013-10-24 11:36:13 UTC) #8
jochen (gone - plz use gerrit)
7 years, 2 months ago (2013-10-24 13:05:15 UTC) #9
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698