Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 30833002: Remove superfluous NotImplemented.h includes (Closed)

Created:
7 years, 2 months ago by lgombos
Modified:
7 years, 2 months ago
CC:
blink-reviews, jamesr, dsinclair, danakj, Rik, groby+blinkspell_chromium.org, Stephen Chennney, pdr.
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove superfluous NotImplemented.h includes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160028

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M Source/core/platform/graphics/ContentDecryptionModuleSession.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/Extensions3D.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCacheSkiaWin.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/skia/FontCustomPlatformDataSkia.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/platform/graphics/win/FontCustomPlatformDataWin.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/Database.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/network/SocketStreamHandle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/EditorClientImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InspectorClientImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/InspectorFrontendClientImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebMediaPlayerClientImpl.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
lgombos
cleanup.
7 years, 2 months ago (2013-10-20 01:05:28 UTC) #1
eseidel
lgtm Do these files not use notImplemented() or do they just get it some other ...
7 years, 2 months ago (2013-10-20 05:26:57 UTC) #2
eseidel
These sorts of changes tend to be fragile (if we're getting the incldue from somewhere ...
7 years, 2 months ago (2013-10-20 05:27:24 UTC) #3
lgombos
On 2013/10/20 05:26:57, eseidel wrote: > lgtm > > Do these files not use notImplemented() ...
7 years, 2 months ago (2013-10-20 14:16:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/l.gombos@samsung.com/30833002/60001
7 years, 2 months ago (2013-10-20 14:16:54 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-20 15:15:50 UTC) #6
Message was sent while issue was closed.
Change committed as 160028

Powered by Google App Engine
This is Rietveld 408576698